* [PATCH] bug-hunting.rst: Clarify bytes sequence format when making "Code:" human-readable
@ 2018-07-12 8:46 Kirill Tkhai
2018-07-12 12:57 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Kirill Tkhai @ 2018-07-12 8:46 UTC (permalink / raw)
To: corbet, christophe.jaillet, ktkhai, linux-doc, linux-kernel
Bytes have to be separated commas, and this is not obvious
for a person, who does not write in pure ".byte" assembler.
Let's clarify this and make visible for people.
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
Documentation/admin-guide/bug-hunting.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/bug-hunting.rst b/Documentation/admin-guide/bug-hunting.rst
index f278b289e260..861ee752eae9 100644
--- a/Documentation/admin-guide/bug-hunting.rst
+++ b/Documentation/admin-guide/bug-hunting.rst
@@ -213,7 +213,7 @@ If you don't have access to the code you can also debug on some crash dumps
.text
.globl foo
foo:
- .byte .... /* bytes from Code: part of OOPS dump */
+ .byte 0x44,0x24,0x04,... /* bytes from Code: part of OOPS dump */
Compile it with "gcc -c -o foo.o foo.s" then look at the output of
"objdump --disassemble foo.o".
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bug-hunting.rst: Clarify bytes sequence format when making "Code:" human-readable
2018-07-12 8:46 [PATCH] bug-hunting.rst: Clarify bytes sequence format when making "Code:" human-readable Kirill Tkhai
@ 2018-07-12 12:57 ` Matthew Wilcox
2018-07-12 14:46 ` Kirill Tkhai
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2018-07-12 12:57 UTC (permalink / raw)
To: Kirill Tkhai; +Cc: corbet, christophe.jaillet, linux-doc, linux-kernel
On Thu, Jul 12, 2018 at 11:46:25AM +0300, Kirill Tkhai wrote:
> Bytes have to be separated commas, and this is not obvious
> for a person, who does not write in pure ".byte" assembler.
> Let's clarify this and make visible for people.
Can we delete the entire section and say "run ./scripts/decodecode"
instead?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bug-hunting.rst: Clarify bytes sequence format when making "Code:" human-readable
2018-07-12 12:57 ` Matthew Wilcox
@ 2018-07-12 14:46 ` Kirill Tkhai
0 siblings, 0 replies; 3+ messages in thread
From: Kirill Tkhai @ 2018-07-12 14:46 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: corbet, christophe.jaillet, linux-doc, linux-kernel
On 12.07.2018 15:57, Matthew Wilcox wrote:
> On Thu, Jul 12, 2018 at 11:46:25AM +0300, Kirill Tkhai wrote:
>> Bytes have to be separated commas, and this is not obvious
>> for a person, who does not write in pure ".byte" assembler.
>> Let's clarify this and make visible for people.
>
> Can we delete the entire section and say "run ./scripts/decodecode"
> instead?
Yeah, it looks so.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-12 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 8:46 [PATCH] bug-hunting.rst: Clarify bytes sequence format when making "Code:" human-readable Kirill Tkhai
2018-07-12 12:57 ` Matthew Wilcox
2018-07-12 14:46 ` Kirill Tkhai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).