* [PATCH] drm: fix drm-get-put.cocci warnings
@ 2018-04-12 5:54 Julia Lawall
2018-04-16 7:45 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2018-04-12 5:54 UTC (permalink / raw)
To: Joel Stanley
Cc: David Airlie, Andrew Jeffery, linux-kernel, dri-devel,
linux-arm-kernel, kbuild-all, linux-aspeed
From: Fengguang Wu <fengguang.wu@intel.com>
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
drm_*_unreference() helpers.
Generated by: scripts/coccinelle/api/drm-get-put.cocci
Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
tree: https://github.com/shenki/linux drm-v1
head: 9680ed7979d5d403c6bde36271a048d62c048180
commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED
GFX
driver
aspeed_gfx_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
@@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
err_unload:
aspeed_gfx_unload(drm);
err_free:
- drm_dev_unref(drm);
+ drm_dev_put(drm);
return ret;
}
@@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
drm_dev_unregister(drm);
aspeed_gfx_unload(drm);
- drm_dev_unref(drm);
+ drm_dev_put(drm);
return 0;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: fix drm-get-put.cocci warnings
2018-04-12 5:54 [PATCH] drm: fix drm-get-put.cocci warnings Julia Lawall
@ 2018-04-16 7:45 ` Daniel Vetter
2018-04-16 9:44 ` Joel Stanley
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Vetter @ 2018-04-16 7:45 UTC (permalink / raw)
To: Julia Lawall
Cc: Joel Stanley, linux-aspeed, David Airlie, linux-kernel,
dri-devel, Andrew Jeffery, kbuild-all, linux-arm-kernel
On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> drm_*_unreference() helpers.
>
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
>
> Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> tree: https://github.com/shenki/linux drm-v1
This isn't an upstream tree (and the aspeed driver isn't in upstream
afaict), so no need for spamming mailing lists I think.
But thanks for doing all this, great motivation to put more of the drm
refactorings into cocci files.
Cheers, Daniel
> head: 9680ed7979d5d403c6bde36271a048d62c048180
> commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED
> GFX
> driver
>
> aspeed_gfx_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
> err_unload:
> aspeed_gfx_unload(drm);
> err_free:
> - drm_dev_unref(drm);
> + drm_dev_put(drm);
>
> return ret;
> }
> @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
>
> drm_dev_unregister(drm);
> aspeed_gfx_unload(drm);
> - drm_dev_unref(drm);
> + drm_dev_put(drm);
>
> return 0;
> }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: fix drm-get-put.cocci warnings
2018-04-16 7:45 ` Daniel Vetter
@ 2018-04-16 9:44 ` Joel Stanley
2018-04-16 12:24 ` Julia Lawall
2018-04-16 12:30 ` [kbuild-all] " Li, Philip
2 siblings, 0 replies; 5+ messages in thread
From: Joel Stanley @ 2018-04-16 9:44 UTC (permalink / raw)
To: Julia Lawall, Joel Stanley, linux-aspeed, David Airlie,
Linux Kernel Mailing List, dri-devel, Andrew Jeffery, kbuild-all,
Linux ARM
On 16 April 2018 at 17:15, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
>> From: Fengguang Wu <fengguang.wu@intel.com>
>>
>> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
>> drm_*_unreference() helpers.
>>
>> Generated by: scripts/coccinelle/api/drm-get-put.cocci
>>
>> Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>> ---
>>
>> tree: https://github.com/shenki/linux drm-v1
>
> This isn't an upstream tree (and the aspeed driver isn't in upstream
> afaict), so no need for spamming mailing lists I think.
Agreed.
Julia, I am happy getting a heads up about changes from the 0day bots,
but I would prefer not to spam others or the lists. If we can't
restrict the emails to just me then perhaps it's best to disable them
for github.com/shenki/linux.git.
FWIW, the aspeed gfx driver has been posted to dri-devel so it will be
upstream soon-ish.
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: fix drm-get-put.cocci warnings
2018-04-16 7:45 ` Daniel Vetter
2018-04-16 9:44 ` Joel Stanley
@ 2018-04-16 12:24 ` Julia Lawall
2018-04-16 12:30 ` [kbuild-all] " Li, Philip
2 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2018-04-16 12:24 UTC (permalink / raw)
To: Daniel Vetter
Cc: Joel Stanley, linux-aspeed, David Airlie, linux-kernel,
dri-devel, Andrew Jeffery, kbuild-all, linux-arm-kernel
On Mon, 16 Apr 2018, Daniel Vetter wrote:
> On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> > From: Fengguang Wu <fengguang.wu@intel.com>
> >
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> > drm_*_unreference() helpers.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
> >
> > tree: https://github.com/shenki/linux drm-v1
>
> This isn't an upstream tree (and the aspeed driver isn't in upstream
> afaict), so no need for spamming mailing lists I think.
Perhaps you can contact Fengguang about this? I just forward to whoever
the automatically generated message says to forward to. And I don't
always remember to include the information about the tree, which comes to
me in another message, so it can indeed be confusing.
>
> But thanks for doing all this, great motivation to put more of the drm
> refactorings into cocci files.
Most welcome :)
julia
> Cheers, Daniel
> > head: 9680ed7979d5d403c6bde36271a048d62c048180
> > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add ASPEED
> > GFX
> > driver
> >
> > aspeed_gfx_drv.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
> > err_unload:
> > aspeed_gfx_unload(drm);
> > err_free:
> > - drm_dev_unref(drm);
> > + drm_dev_put(drm);
> >
> > return ret;
> > }
> > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
> >
> > drm_dev_unregister(drm);
> > aspeed_gfx_unload(drm);
> > - drm_dev_unref(drm);
> > + drm_dev_put(drm);
> >
> > return 0;
> > }
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings
2018-04-16 7:45 ` Daniel Vetter
2018-04-16 9:44 ` Joel Stanley
2018-04-16 12:24 ` Julia Lawall
@ 2018-04-16 12:30 ` Li, Philip
2 siblings, 0 replies; 5+ messages in thread
From: Li, Philip @ 2018-04-16 12:30 UTC (permalink / raw)
To: Daniel Vetter, Julia Lawall
Cc: linux-aspeed, David Airlie, linux-kernel, dri-devel,
Andrew Jeffery, Joel Stanley, linux-arm-kernel, kbuild-all
> Subject: Re: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings
>
> On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> > From: Fengguang Wu <fengguang.wu@intel.com>
> >
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> > drm_*_unreference() helpers.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
> >
> > tree: https://github.com/shenki/linux drm-v1
>
> This isn't an upstream tree (and the aspeed driver isn't in upstream
> afaict), so no need for spamming mailing lists I think.
thanks for feedback Daniel, we will mark this repo as private one to avoid
reporting to larger mailing list.
>
> But thanks for doing all this, great motivation to put more of the drm
> refactorings into cocci files.
>
> Cheers, Daniel
> > head: 9680ed7979d5d403c6bde36271a048d62c048180
> > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add
> ASPEED
> > GFX
> > driver
> >
> > aspeed_gfx_drv.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
> > err_unload:
> > aspeed_gfx_unload(drm);
> > err_free:
> > - drm_dev_unref(drm);
> > + drm_dev_put(drm);
> >
> > return ret;
> > }
> > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
> >
> > drm_dev_unregister(drm);
> > aspeed_gfx_unload(drm);
> > - drm_dev_unref(drm);
> > + drm_dev_put(drm);
> >
> > return 0;
> > }
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-16 12:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 5:54 [PATCH] drm: fix drm-get-put.cocci warnings Julia Lawall
2018-04-16 7:45 ` Daniel Vetter
2018-04-16 9:44 ` Joel Stanley
2018-04-16 12:24 ` Julia Lawall
2018-04-16 12:30 ` [kbuild-all] " Li, Philip
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).