linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3
@ 2020-12-03 23:14 Arnd Bergmann
  2020-12-04 17:48 ` Srinivas Kandagatla
  2020-12-04 23:30 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-12-03 23:14 UTC (permalink / raw)
  To: Patrick Lai, Banajit Goswami, Liam Girdwood, Mark Brown
  Cc: Arnd Bergmann, Jaroslav Kysela, Takashi Iwai,
	Srinivas Kandagatla, Ajit Pandey, Rohit kumar, Randy Dunlap,
	alsa-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The previous fix left another warning in randconfig builds:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
  Selected by [y]:
  - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]

Add one more dependency for this one.

Fixes: 2bc8831b135c ("ASoC: qcom: fix SDM845 & QDSP6 dependencies more")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 27f93006be96..cc7c1de2f1d9 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -106,6 +106,7 @@ config SND_SOC_QDSP6
 config SND_SOC_MSM8996
 	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
 	depends on QCOM_APR
+	depends on COMMON_CLK
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
 	help
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3
  2020-12-03 23:14 [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3 Arnd Bergmann
@ 2020-12-04 17:48 ` Srinivas Kandagatla
  2020-12-04 23:30 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2020-12-04 17:48 UTC (permalink / raw)
  To: Arnd Bergmann, Patrick Lai, Banajit Goswami, Liam Girdwood, Mark Brown
  Cc: Arnd Bergmann, Jaroslav Kysela, Takashi Iwai, Ajit Pandey,
	Rohit kumar, Randy Dunlap, alsa-devel, linux-kernel



On 03/12/2020 23:14, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The previous fix left another warning in randconfig builds:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
>    Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
>    Selected by [y]:
>    - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]
> 
> Add one more dependency for this one.
> 
> Fixes: 2bc8831b135c ("ASoC: qcom: fix SDM845 & QDSP6 dependencies more")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for the patch,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> ---
>   sound/soc/qcom/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 27f93006be96..cc7c1de2f1d9 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -106,6 +106,7 @@ config SND_SOC_QDSP6
>   config SND_SOC_MSM8996
>   	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
>   	depends on QCOM_APR
> +	depends on COMMON_CLK
>   	select SND_SOC_QDSP6
>   	select SND_SOC_QCOM_COMMON
>   	help
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3
  2020-12-03 23:14 [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3 Arnd Bergmann
  2020-12-04 17:48 ` Srinivas Kandagatla
@ 2020-12-04 23:30 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-12-04 23:30 UTC (permalink / raw)
  To: Patrick Lai, Arnd Bergmann, Banajit Goswami, Liam Girdwood
  Cc: linux-kernel, Rohit kumar, Randy Dunlap, Srinivas Kandagatla,
	Ajit Pandey, alsa-devel, Takashi Iwai, Arnd Bergmann

On Fri, 4 Dec 2020 00:14:18 +0100, Arnd Bergmann wrote:
> The previous fix left another warning in randconfig builds:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n]
>   Selected by [y]:
>   - SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: qcom: fix QDSP6 dependencies, attempt #3
      commit: b1b8eb1283c90a953089d988930d7b6156418958

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-04 23:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 23:14 [PATCH] ASoC: qcom: fix QDSP6 dependencies, attempt #3 Arnd Bergmann
2020-12-04 17:48 ` Srinivas Kandagatla
2020-12-04 23:30 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).