From: "Chen, Jiaxi" <jiaxi.chen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
seanjc@google.com, pbonzini@redhat.com, ndesaulniers@google.com,
alexandre.belloni@bootlin.com, peterz@infradead.org,
jpoimboe@kernel.org, chang.seok.bae@intel.com,
pawan.kumar.gupta@linux.intel.com, babu.moger@amd.com,
jmattson@google.com, sandipan.das@amd.com, tony.luck@intel.com,
sathyanarayanan.kuppuswamy@linux.intel.com, fenghua.yu@intel.com,
keescook@chromium.org, jane.malalane@citrix.com,
nathan@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] x86: KVM: Enable AVX-VNNI-INT8 CPUID and expose it to guest
Date: Thu, 20 Oct 2022 15:13:14 +0800 [thread overview]
Message-ID: <83572272-a54a-29c8-ce69-fdcc7497b77a@linux.intel.com> (raw)
In-Reply-To: <Y0+6tJ7MiZWbYK5l@zn.tnic>
在 2022/10/19 16:52, Borislav Petkov 写道:
> On Wed, Oct 19, 2022 at 04:47:32PM +0800, Jiaxi Chen wrote:
>> AVX-VNNI-INT8 is a new set of instructions in the latest Intel platform
>> Sierra Forest. It multiplies the individual bytes of two unsigned or
>> unsigned source operands, then add and accumulate the results into the
>> destination dword element size operand. This instruction allows for the
>> platform to have superior AI capabilities.
>>
>> The bit definition:
>> CPUID.(EAX=7,ECX=1):EDX[bit 4]
>>
>> This patch enables this CPUID in the kernel feature bits and expose it to
>> guest OS. Since the CPUID involves a bit of EDX (EAX=7,ECX=1) which has not
>> been enumerated yet, this patch adds CPUID_7_1_EDX to CPUID subleaves. At
>> the same time, word 20 is newly-defined in CPU features for CPUID level
>
> For all your commit messages:
>
> Avoid having "This patch" or "This commit" in the commit message. It is
> tautologically useless.
Will follow this in the future. Thanks.
>
> Also, do
>
> $ git grep 'This patch' Documentation/process
>
> for more details.
>
> For this particular one, use scattered.c instead of adding a new leaf.
>
> Thx.
>
next prev parent reply other threads:[~2022-10-20 7:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:47 [PATCH 0/6] x86: KVM: Expose CPUID to guest for new Intel platform instructions Jiaxi Chen
2022-10-19 8:47 ` [PATCH 1/6] x86: KVM: Enable CMPccXADD CPUID and expose it to guest Jiaxi Chen
2022-10-19 15:15 ` Sean Christopherson
2022-10-20 7:27 ` Chen, Jiaxi
2022-10-26 3:40 ` Jiaxi Chen
2022-10-26 17:15 ` Borislav Petkov
2022-10-27 2:27 ` Jiaxi Chen
2022-11-01 9:07 ` Jiaxi Chen
2022-11-01 15:07 ` Sean Christopherson
2022-11-03 2:35 ` Jiaxi Chen
2022-10-19 8:47 ` [PATCH 2/6] x86: KVM: Enable AMX-FP16 " Jiaxi Chen
2022-11-02 18:14 ` Dave Hansen
2022-11-02 18:16 ` Paolo Bonzini
2022-11-02 18:21 ` Dave Hansen
2022-11-03 2:38 ` Jiaxi Chen
2022-10-19 8:47 ` [PATCH 3/6] x86: KVM: Enable AVX-IFMA " Jiaxi Chen
2022-10-19 8:47 ` [PATCH 4/6] x86: KVM: Enable AVX-VNNI-INT8 " Jiaxi Chen
2022-10-19 8:52 ` Borislav Petkov
2022-10-19 14:57 ` Sean Christopherson
2022-10-19 15:09 ` Sean Christopherson
2022-10-26 3:33 ` Jiaxi Chen
2022-10-20 7:13 ` Chen, Jiaxi [this message]
2022-10-19 8:47 ` [PATCH 5/6] x86: KVM: Enable AVX-NE-CONVERT " Jiaxi Chen
2022-10-19 8:47 ` [PATCH 6/6] x86: KVM: Enable PREFETCHIT0/1 " Jiaxi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83572272-a54a-29c8-ce69-fdcc7497b77a@linux.intel.com \
--to=jiaxi.chen@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jane.malalane@citrix.com \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).