From: Stefan Agner <stefan@agner.ch>
To: Mark Brown <broonie@kernel.org>
Cc: perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Stefan Agner <stefan.agner@toradex.com>
Subject: Re: [PATCH] ASoC: soc-core: remove error due to probe deferral
Date: Thu, 08 Aug 2019 14:59:09 +0200 [thread overview]
Message-ID: <83988e57c768513425ed79eac6744ed8@agner.ch> (raw)
In-Reply-To: <20190808124437.GD3795@sirena.co.uk>
On 2019-08-08 14:44, Mark Brown wrote:
> On Thu, Aug 08, 2019 at 02:36:55PM +0200, Stefan Agner wrote:
>> From: Stefan Agner <stefan.agner@toradex.com>
>>
>> Deferred probes shouldn't cause error messages in the boot log. Avoid
>> printing with dev_err() in case EPROBE_DEFER is the return value.
>
> No, they absolutely should tell the user why they are deferring so the
> user has some information to go on when they're trying to figure out why
> their device isn't instantiating.
Hm, I see, if the driver defers and does not manage in the end, then the
messages are indeed helpful.
But can we lower severity, e.g. to dev_info? In my case it succeeds in
the end, just defers about 6 times. I have 3 links which then leads to
18 error messages which confuse users... From what I can see
soc_init_dai_link() would print dev_err in case there is an actual
error.
--
Stefan
next prev parent reply other threads:[~2019-08-08 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 12:36 [PATCH] ASoC: soc-core: remove error due to probe deferral Stefan Agner
2019-08-08 12:44 ` Mark Brown
2019-08-08 12:59 ` Stefan Agner [this message]
2019-08-08 13:00 ` Takashi Iwai
2019-08-08 13:02 ` Mark Brown
2019-08-08 13:14 ` Takashi Iwai
2019-08-08 13:16 ` Stefan Agner
2019-08-08 19:27 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2019-01-18 9:55 Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83988e57c768513425ed79eac6744ed8@agner.ch \
--to=stefan@agner.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stefan.agner@toradex.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).