From: Stefan Agner <stefan@agner.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
Stefan Agner <stefan.agner@toradex.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-core: remove error due to probe deferral
Date: Thu, 08 Aug 2019 15:16:53 +0200 [thread overview]
Message-ID: <cd3fd8b9ce6e4f9820197c70dfc42b67@agner.ch> (raw)
In-Reply-To: <s5hftmbiyuc.wl-tiwai@suse.de>
On 2019-08-08 15:14, Takashi Iwai wrote:
> On Thu, 08 Aug 2019 15:02:17 +0200,
> Mark Brown wrote:
>>
>> On Thu, Aug 08, 2019 at 03:00:06PM +0200, Takashi Iwai wrote:
>> > Mark Brown wrote:
>>
>> > > No, they absolutely should tell the user why they are deferring so the
>> > > user has some information to go on when they're trying to figure out why
>> > > their device isn't instantiating.
>>
>> > But it's no real error that *must* be printed on the console, either.
>> > Maybe downgrading the printk level?
>>
>> Yes, downgrading can be OK though it does bloat the code.
>
> I guess we can use dev_printk() with the conditional level choice.
>
How about use dev_info always? We get a dev_err message from
soc_init_dai_link in error cases...
ret = soc_init_dai_link(card, dai_link);
if (ret && ret != -EPROBE_DEFER) {
dev_info(card->dev, "ASoC: failed to init link %s: %d\n",
dai_link->name, ret);
}
if (ret) {
soc_cleanup_platform(card);
mutex_unlock(&client_mutex);
return ret;
}
--
Stefan
next prev parent reply other threads:[~2019-08-08 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 12:36 [PATCH] ASoC: soc-core: remove error due to probe deferral Stefan Agner
2019-08-08 12:44 ` Mark Brown
2019-08-08 12:59 ` Stefan Agner
2019-08-08 13:00 ` Takashi Iwai
2019-08-08 13:02 ` Mark Brown
2019-08-08 13:14 ` Takashi Iwai
2019-08-08 13:16 ` Stefan Agner [this message]
2019-08-08 19:27 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2019-01-18 9:55 Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3fd8b9ce6e4f9820197c70dfc42b67@agner.ch \
--to=stefan@agner.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stefan.agner@toradex.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).