From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Christoph Lameter" <clameter@engr.sgi.com>
Cc: akpm@osdl.org, alokk@calsoftinc.com, manfred@colorfullife.com,
linux-kernel@vger.kernel.org
Subject: Re: slab: Remove SLAB_NO_REAP option
Date: Thu, 23 Feb 2006 09:46:44 +0200 [thread overview]
Message-ID: <84144f020602222346m70a41867vd2387fbfc2cfe547@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0602221428510.30219@schroedinger.engr.sgi.com>
Hi,
On 2/23/06, Christoph Lameter <clameter@engr.sgi.com> wrote:
> SLAB_NO_REAP is documented as an option that will cause this slab
> not to be reaped under memory pressure. However, that is not what
> happens. The only thing that SLAB_NO_REAP controls at the moment
> is the reclaim of the unused slab elements that were allocated in
> batch in cache_reap(). Cache_reap() is run every few seconds
> independently of memory pressure.
>
> Could we remove the whole thing? Its only used by three slabs
> anyways and I cannot find a reason for having this option.
Looks good, and I have been meaning to do this myself as well.
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
P.S. Please use penberg@cs.helsinki.fi, not the gmail one. Thanks.
Pekka
next prev parent reply other threads:[~2006-02-23 7:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-22 22:34 slab: Remove SLAB_NO_REAP option Christoph Lameter
2006-02-23 7:46 ` Pekka Enberg [this message]
2006-02-23 7:54 ` Alok Kataria
2006-02-23 8:48 ` Pekka Enberg
2006-02-23 9:35 Alok Kataria
2006-02-23 10:09 ` Andrew Morton
2006-02-23 11:34 ` Pekka J Enberg
2006-02-23 17:20 ` Christoph Lameter
2006-02-23 18:36 ` Pekka Enberg
2006-02-23 18:47 ` Christoph Lameter
2006-02-23 19:17 ` Ravikiran G Thirumalai
2006-02-23 19:24 ` Christoph Lameter
2006-02-24 7:36 ` Pekka Enberg
2006-02-24 16:19 ` Christoph Lameter
2006-02-25 22:15 ` Pekka Enberg
2006-02-23 17:17 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020602222346m70a41867vd2387fbfc2cfe547@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=alokk@calsoftinc.com \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).