From: Christoph Lameter <clameter@engr.sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <clameter@engr.sgi.com>,
Andrew Morton <akpm@osdl.org>,
Alok Kataria <alok.kataria@calsoftinc.com>,
manfred@colorfullife.com, linux-kernel@vger.kernel.org
Subject: Re: slab: Remove SLAB_NO_REAP option
Date: Thu, 23 Feb 2006 10:47:53 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0602231044210.13228@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <1140719812.11455.1.camel@localhost>
On Thu, 23 Feb 2006, Pekka Enberg wrote:
> Look at the loop, it is redundant work (like acquiring/releasing a
> spinlock). The cache_cache is practically static, which is why it makes
> sense to leave it alone.
There is a loop but its broken by
p = l3->slabs_free.next;
if (p == &(l3->slabs_free))
break;
One cache_reap() may scan the free list but once its free the code is
skipped.
There are potentially large amounts of other caches around that are also
basically static and which also would need any bypass that we may
implement.
next prev parent reply other threads:[~2006-02-23 18:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 9:35 slab: Remove SLAB_NO_REAP option Alok Kataria
2006-02-23 10:09 ` Andrew Morton
2006-02-23 11:34 ` Pekka J Enberg
2006-02-23 17:20 ` Christoph Lameter
2006-02-23 18:36 ` Pekka Enberg
2006-02-23 18:47 ` Christoph Lameter [this message]
2006-02-23 19:17 ` Ravikiran G Thirumalai
2006-02-23 19:24 ` Christoph Lameter
2006-02-24 7:36 ` Pekka Enberg
2006-02-24 16:19 ` Christoph Lameter
2006-02-25 22:15 ` Pekka Enberg
2006-02-23 17:17 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2006-02-22 22:34 Christoph Lameter
2006-02-23 7:46 ` Pekka Enberg
2006-02-23 7:54 ` Alok Kataria
2006-02-23 8:48 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0602231044210.13228@schroedinger.engr.sgi.com \
--to=clameter@engr.sgi.com \
--cc=akpm@osdl.org \
--cc=alok.kataria@calsoftinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).