From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: "Ahmed S. Darwish" <darwish.07@gmail.com>,
"Rolf Eike Beer" <eike-kernel@sf-tec.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts
Date: Fri, 5 Jan 2007 12:39:08 +0200 [thread overview]
Message-ID: <84144f020701050239q290849eahd3fc90af2c611d3@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701050513360.23145@localhost.localdomain>
On 1/5/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
> in this case, as mr. beer suggests, you should also check if this
> represents a kmalloc->kzalloc cleanup (there's lots of those), and
> also see if you can replace one of these:
>
> sizeof(struct blah)
>
> with one of these:
>
> sizeof(*blahptr)
>
> according to the CodingStyle guide.
Unfortunately, not all maintainers like sizeof() changes, so you're
better off leaving them as-is.
next prev parent reply other threads:[~2007-01-05 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 6:36 [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts Ahmed S. Darwish
2007-01-05 6:56 ` Robert P. J. Day
2007-01-05 7:14 ` Ahmed S. Darwish
2007-01-05 8:10 ` Rolf Eike Beer
2007-01-05 10:06 ` Ahmed S. Darwish
2007-01-05 10:18 ` Robert P. J. Day
2007-01-05 10:39 ` Pekka Enberg [this message]
2007-01-05 10:51 ` Alan
2007-01-05 10:41 ` Robert P. J. Day
2007-01-05 11:03 ` Ahmed S. Darwish
2007-01-06 2:36 ` Ahmed S. Darwish
2007-01-06 7:35 ` Robert P. J. Day
2007-01-05 10:26 ` Rolf Eike Beer
2007-01-05 10:32 ` Ahmed S. Darwish
2007-01-05 11:54 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020701050239q290849eahd3fc90af2c611d3@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=darwish.07@gmail.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).