From: "Robert P. J. Day" <rpjday@mindspring.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts
Date: Fri, 5 Jan 2007 05:18:40 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701050513360.23145@localhost.localdomain> (raw)
In-Reply-To: <20070105100610.GA382@Ahmed>
On Fri, 5 Jan 2007, Ahmed S. Darwish wrote:
> On Fri, Jan 05, 2007 at 09:10:01AM +0100, Rolf Eike Beer wrote:
> > Ahmed S. Darwish wrote:
> > > Remove unnecessary kmalloc casts in drivers/char/tty_io.c
> > >
> > > Signed-off-by: Ahmed Darwish <darwish.07@gmail.com>
> >
> > if (!*ltp_loc) {
> > - ltp = (struct ktermios *) kmalloc(sizeof(struct ktermios),
> > - GFP_KERNEL);
> > + ltp = kmalloc(sizeof(struct ktermios), GFP_KERNEL);
> > ^^^^^^^
> > if (!ltp)
> > goto free_mem_out;
> > memset(ltp, 0, sizeof(struct ktermios));
> > ^^^^^^
> > kzalloc
> >
> > if (!*o_ltp_loc) {
> > - o_ltp = (struct ktermios *)
> > - kmalloc(sizeof(struct ktermios), GFP_KERNEL);
> > + o_ltp = kmalloc(sizeof(struct ktermios), GFP_KERNEL);
> > ^^^^^^^
> > if (!o_ltp)
> > goto free_mem_out;
> > memset(o_ltp, 0, sizeof(struct ktermios));
> > ^^^^^^
> > kzalloc
>
> Currently I'm dropping this patch and writing a big patch to remove
> all the k[mzc]alloc castings in the 20-rc3 tree as suggested by Mr.
> Robert Day. I think this will be better done in another patch to let
> every patch do one single thing. right ?
almost. as i've learned (the hard way), while each patch should
logically accomplish one thing, while you're there, you might as well
clean up other issues *at the same locations*.
in this case, as mr. beer suggests, you should also check if this
represents a kmalloc->kzalloc cleanup (there's lots of those), and
also see if you can replace one of these:
sizeof(struct blah)
with one of these:
sizeof(*blahptr)
according to the CodingStyle guide.
rday
p.s. just FYI, i have a patch that does most of this, but i was going
to hold off submitting it until 2.6.20 had arrived. but if you want
to take a shot at it, it's all yours.
next prev parent reply other threads:[~2007-01-05 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 6:36 [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts Ahmed S. Darwish
2007-01-05 6:56 ` Robert P. J. Day
2007-01-05 7:14 ` Ahmed S. Darwish
2007-01-05 8:10 ` Rolf Eike Beer
2007-01-05 10:06 ` Ahmed S. Darwish
2007-01-05 10:18 ` Robert P. J. Day [this message]
2007-01-05 10:39 ` Pekka Enberg
2007-01-05 10:51 ` Alan
2007-01-05 10:41 ` Robert P. J. Day
2007-01-05 11:03 ` Ahmed S. Darwish
2007-01-06 2:36 ` Ahmed S. Darwish
2007-01-06 7:35 ` Robert P. J. Day
2007-01-05 10:26 ` Rolf Eike Beer
2007-01-05 10:32 ` Ahmed S. Darwish
2007-01-05 11:54 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701050513360.23145@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=darwish.07@gmail.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).