* [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition
@ 2020-11-27 18:29 trix
2020-11-27 18:37 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-11-27 18:29 UTC (permalink / raw)
To: willy, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
The macro use will already have a semicolon.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
index d9a045f9858c..f3b3345c1766 100644
--- a/drivers/scsi/sym53c8xx_2/sym_glue.c
+++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
@@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len, char *verb)
#define SKIP_SPACES(ptr, len) \
if ((arg_len = sym_skip_spaces(ptr, len)) < 1) \
return -EINVAL; \
- ptr += arg_len; len -= arg_len;
+ ptr += arg_len; len -= arg_len
#define GET_INT_ARG(ptr, len, v) \
if (!(arg_len = get_int_arg(ptr, len, &(v)))) \
return -EINVAL; \
- ptr += arg_len; len -= arg_len;
+ ptr += arg_len; len -= arg_len
/*
--
2.18.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition
2020-11-27 18:29 [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition trix
@ 2020-11-27 18:37 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2020-11-27 18:37 UTC (permalink / raw)
To: trix, willy, martin.petersen; +Cc: linux-scsi, linux-kernel
On Fri, 2020-11-27 at 10:29 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c
> b/drivers/scsi/sym53c8xx_2/sym_glue.c
> index d9a045f9858c..f3b3345c1766 100644
> --- a/drivers/scsi/sym53c8xx_2/sym_glue.c
> +++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
> @@ -1001,12 +1001,12 @@ static int is_keyword(char *ptr, int len,
> char *verb)
> #define SKIP_SPACES(ptr, len)
> \
> if ((arg_len = sym_skip_spaces(ptr, len)) < 1)
> \
> return -EINVAL;
> \
> - ptr += arg_len; len -= arg_len;
> + ptr += arg_len; len -= arg_len
>
> #define GET_INT_ARG(ptr, len, v)
> \
> if (!(arg_len = get_int_arg(ptr, len, &(v))))
> \
> return -EINVAL;
> \
> - ptr += arg_len; len -= arg_len;
> + ptr += arg_len; len -= arg_len
Those macros have the wrong form which can lead to actual bugs and this
cosmetic change does nothing to fix it. If the goal here is to get the
code base into better shape, please fix the bugs.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-27 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 18:29 [PATCH] [SCSI] sym53c8xx: remove trailing semicolon in macro definition trix
2020-11-27 18:37 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).