* [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier
@ 2018-11-08 11:02 Colin King
2018-11-08 11:20 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Colin King @ 2018-11-08 11:02 UTC (permalink / raw)
To: Dmitry Osipenko, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Thierry Reding, Jonathan Hunter, linux-media, linux-tegra, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
build warning. Fix this by using the %lu format specifer.
Cleans up warning:
drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
index 6f06061a40d9..66cf14212c14 100644
--- a/drivers/staging/media/tegra-vde/tegra-vde.c
+++ b/drivers/staging/media/tegra-vde/tegra-vde.c
@@ -262,7 +262,7 @@ static void tegra_vde_setup_iram_tables(struct tegra_vde *vde,
value |= frame->frame_num;
dev_dbg(vde->miscdev.parent,
- "\tFrame %d: frame_num = %d B_frame = %d\n",
+ "\tFrame %d: frame_num = %d B_frame = %lu\n",
i + 1, frame->frame_num,
(frame->flags & FLAG_B_FRAME));
} else {
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier
2018-11-08 11:02 [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier Colin King
@ 2018-11-08 11:20 ` Greg Kroah-Hartman
2018-11-08 11:39 ` Dmitry Osipenko
2018-11-09 14:32 ` Hans Verkuil
2 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-11-08 11:20 UTC (permalink / raw)
To: Colin King
Cc: Dmitry Osipenko, Mauro Carvalho Chehab, Thierry Reding,
Jonathan Hunter, linux-media, linux-tegra, devel,
kernel-janitors, linux-kernel
On Thu, Nov 08, 2018 at 11:02:24AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
> build warning. Fix this by using the %lu format specifer.
>
> Cleans up warning:
> drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
> specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
>
> Fixes: 42e764d05712 ("staging: tegravde: replace bit assignment with macro")
> Cc: Ioannis Valasakis <code@wizofe.uk>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
> index 6f06061a40d9..66cf14212c14 100644
> --- a/drivers/staging/media/tegra-vde/tegra-vde.c
> +++ b/drivers/staging/media/tegra-vde/tegra-vde.c
> @@ -262,7 +262,7 @@ static void tegra_vde_setup_iram_tables(struct tegra_vde *vde,
> value |= frame->frame_num;
>
> dev_dbg(vde->miscdev.parent,
> - "\tFrame %d: frame_num = %d B_frame = %d\n",
> + "\tFrame %d: frame_num = %d B_frame = %lu\n",
> i + 1, frame->frame_num,
> (frame->flags & FLAG_B_FRAME));
> } else {
> --
> 2.19.1
Thanks for this, you beat me too it :)
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier
2018-11-08 11:02 [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier Colin King
2018-11-08 11:20 ` Greg Kroah-Hartman
@ 2018-11-08 11:39 ` Dmitry Osipenko
2018-11-09 14:32 ` Hans Verkuil
2 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2018-11-08 11:39 UTC (permalink / raw)
To: Colin King, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Thierry Reding, Jonathan Hunter, linux-media, linux-tegra, devel
Cc: kernel-janitors, linux-kernel
On 08.11.2018 14:02, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
> build warning. Fix this by using the %lu format specifer.
>
> Cleans up warning:
> drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
> specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
> index 6f06061a40d9..66cf14212c14 100644
> --- a/drivers/staging/media/tegra-vde/tegra-vde.c
> +++ b/drivers/staging/media/tegra-vde/tegra-vde.c
> @@ -262,7 +262,7 @@ static void tegra_vde_setup_iram_tables(struct tegra_vde *vde,
> value |= frame->frame_num;
>
> dev_dbg(vde->miscdev.parent,
> - "\tFrame %d: frame_num = %d B_frame = %d\n",
> + "\tFrame %d: frame_num = %d B_frame = %lu\n",
> i + 1, frame->frame_num,
> (frame->flags & FLAG_B_FRAME));
> } else {
>
Thanks,
Acked-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier
2018-11-08 11:02 [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier Colin King
2018-11-08 11:20 ` Greg Kroah-Hartman
2018-11-08 11:39 ` Dmitry Osipenko
@ 2018-11-09 14:32 ` Hans Verkuil
2018-11-13 16:52 ` Dmitry Osipenko
2 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2018-11-09 14:32 UTC (permalink / raw)
To: Colin King, Dmitry Osipenko, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter, linux-media,
linux-tegra, devel
Cc: kernel-janitors, linux-kernel
On 11/08/18 12:02, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
> build warning. Fix this by using the %lu format specifer.
>
> Cleans up warning:
> drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
> specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
> index 6f06061a40d9..66cf14212c14 100644
> --- a/drivers/staging/media/tegra-vde/tegra-vde.c
> +++ b/drivers/staging/media/tegra-vde/tegra-vde.c
> @@ -262,7 +262,7 @@ static void tegra_vde_setup_iram_tables(struct tegra_vde *vde,
> value |= frame->frame_num;
>
> dev_dbg(vde->miscdev.parent,
> - "\tFrame %d: frame_num = %d B_frame = %d\n",
> + "\tFrame %d: frame_num = %d B_frame = %lu\n",
> i + 1, frame->frame_num,
> (frame->flags & FLAG_B_FRAME));
> } else {
>
Compiling for i686 gives:
In file included from /home/hans/work/build/media-git/include/linux/printk.h:336,
from /home/hans/work/build/media-git/include/linux/kernel.h:14,
from /home/hans/work/build/media-git/include/linux/clk.h:16,
from /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:12:
/home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c: In function 'tegra_vde_setup_iram_tables':
/home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:265:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'u32' {aka 'unsigned int'} [-Wformat=]
"\tFrame %d: frame_num = %d B_frame = %lu\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/hans/work/build/media-git/include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
__dynamic_dev_dbg(&descriptor, dev, fmt, \
^~~
/home/hans/work/build/media-git/include/linux/device.h:1463:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
/home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:264:4: note: in expansion of macro 'dev_dbg'
dev_dbg(vde->miscdev.parent,
^~~~~~~
Should it be %zu?
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier
2018-11-09 14:32 ` Hans Verkuil
@ 2018-11-13 16:52 ` Dmitry Osipenko
2018-11-13 17:12 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2018-11-13 16:52 UTC (permalink / raw)
To: Hans Verkuil, Colin King, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter, linux-media,
linux-tegra, devel
Cc: kernel-janitors, linux-kernel
On 09.11.2018 17:32, Hans Verkuil wrote:
> On 11/08/18 12:02, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
>> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
>> build warning. Fix this by using the %lu format specifer.
>>
>> Cleans up warning:
>> drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
>> specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
>> index 6f06061a40d9..66cf14212c14 100644
>> --- a/drivers/staging/media/tegra-vde/tegra-vde.c
>> +++ b/drivers/staging/media/tegra-vde/tegra-vde.c
>> @@ -262,7 +262,7 @@ static void tegra_vde_setup_iram_tables(struct tegra_vde *vde,
>> value |= frame->frame_num;
>>
>> dev_dbg(vde->miscdev.parent,
>> - "\tFrame %d: frame_num = %d B_frame = %d\n",
>> + "\tFrame %d: frame_num = %d B_frame = %lu\n",
>> i + 1, frame->frame_num,
>> (frame->flags & FLAG_B_FRAME));
>> } else {
>>
>
> Compiling for i686 gives:
>
> In file included from /home/hans/work/build/media-git/include/linux/printk.h:336,
> from /home/hans/work/build/media-git/include/linux/kernel.h:14,
> from /home/hans/work/build/media-git/include/linux/clk.h:16,
> from /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:12:
> /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c: In function 'tegra_vde_setup_iram_tables':
> /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:265:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'u32' {aka 'unsigned int'} [-Wformat=]
> "\tFrame %d: frame_num = %d B_frame = %lu\n",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/hans/work/build/media-git/include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
> __dynamic_dev_dbg(&descriptor, dev, fmt, \
> ^~~
> /home/hans/work/build/media-git/include/linux/device.h:1463:23: note: in expansion of macro 'dev_fmt'
> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
> ^~~~~~~
> /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:264:4: note: in expansion of macro 'dev_dbg'
> dev_dbg(vde->miscdev.parent,
> ^~~~~~~
>
> Should it be %zu?
Same on ARM32. Yes, it should be either %zu or "!!(frame->flags & FLAG_B_FRAME)".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier
2018-11-13 16:52 ` Dmitry Osipenko
@ 2018-11-13 17:12 ` Dmitry Osipenko
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2018-11-13 17:12 UTC (permalink / raw)
To: Hans Verkuil, Colin King, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Thierry Reding, Jonathan Hunter, linux-media,
linux-tegra, devel
Cc: kernel-janitors, linux-kernel
On 13.11.2018 19:52, Dmitry Osipenko wrote:
> On 09.11.2018 17:32, Hans Verkuil wrote:
>> On 11/08/18 12:02, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because
>>> of the use of the BIT() macro when defining FLAG_B_FRAME and causing a
>>> build warning. Fix this by using the %lu format specifer.
>>>
>>> Cleans up warning:
>>> drivers/staging/media/tegra-vde/tegra-vde.c:267:5: warning: format
>>> specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/staging/media/tegra-vde/tegra-vde.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/media/tegra-vde/tegra-vde.c b/drivers/staging/media/tegra-vde/tegra-vde.c
>>> index 6f06061a40d9..66cf14212c14 100644
>>> --- a/drivers/staging/media/tegra-vde/tegra-vde.c
>>> +++ b/drivers/staging/media/tegra-vde/tegra-vde.c
>>> @@ -262,7 +262,7 @@ static void tegra_vde_setup_iram_tables(struct tegra_vde *vde,
>>> value |= frame->frame_num;
>>>
>>> dev_dbg(vde->miscdev.parent,
>>> - "\tFrame %d: frame_num = %d B_frame = %d\n",
>>> + "\tFrame %d: frame_num = %d B_frame = %lu\n",
>>> i + 1, frame->frame_num,
>>> (frame->flags & FLAG_B_FRAME));
>>> } else {
>>>
>>
>> Compiling for i686 gives:
>>
>> In file included from /home/hans/work/build/media-git/include/linux/printk.h:336,
>> from /home/hans/work/build/media-git/include/linux/kernel.h:14,
>> from /home/hans/work/build/media-git/include/linux/clk.h:16,
>> from /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:12:
>> /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c: In function 'tegra_vde_setup_iram_tables':
>> /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:265:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'u32' {aka 'unsigned int'} [-Wformat=]
>> "\tFrame %d: frame_num = %d B_frame = %lu\n",
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> /home/hans/work/build/media-git/include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
>> __dynamic_dev_dbg(&descriptor, dev, fmt, \
>> ^~~
>> /home/hans/work/build/media-git/include/linux/device.h:1463:23: note: in expansion of macro 'dev_fmt'
>> dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
>> ^~~~~~~
>> /home/hans/work/build/media-git/drivers/staging/media/tegra-vde/tegra-vde.c:264:4: note: in expansion of macro 'dev_dbg'
>> dev_dbg(vde->miscdev.parent,
>> ^~~~~~~
>>
>> Should it be %zu?
>
> Same on ARM32. Yes, it should be either %zu or "!!(frame->flags & FLAG_B_FRAME)".
>
Actually this not a problem with a more recent -next. My bad, sorry for the noise.
Probably I should try again with a "trace points" patch that removes those debug messages.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-13 17:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 11:02 [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier Colin King
2018-11-08 11:20 ` Greg Kroah-Hartman
2018-11-08 11:39 ` Dmitry Osipenko
2018-11-09 14:32 ` Hans Verkuil
2018-11-13 16:52 ` Dmitry Osipenko
2018-11-13 17:12 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).