* [PATCH 1/2] drm: fsl-dcu: select CONFIG_DRM_GEM_CMA_HELPER
@ 2021-12-04 17:46 Arnd Bergmann
2021-12-04 17:46 ` [PATCH 2/2] drm: aspeed: " Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2021-12-04 17:46 UTC (permalink / raw)
To: Stefan Agner, Alison Wang, David Airlie, Daniel Vetter,
Thomas Zimmermann
Cc: Arnd Bergmann, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The fsl-dcu driver uses the gem_cma_helper code, but does
noto enforce enabling this through Kconfig:
arm-linux-gnueabi-ld: drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o:(.rodata+0x32c): undefined reference to `drm_gem_cma_prime_import_sg_table'
arm-linux-gnueabi-ld: drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o:(.rodata+0x334): undefined reference to `drm_gem_cma_dumb_create'
arm-linux-gnueabi-ld: drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.o: in function `fsl_dcu_drm_plane_atomic_update':
fsl_dcu_drm_plane.c:(.text+0x144): undefined reference to `drm_fb_cma_get_gem_obj'
Add the same 'select' that is used in other such drivers.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/fsl-dcu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
index 2a13ea5c8539..e95e96c565ba 100644
--- a/drivers/gpu/drm/fsl-dcu/Kconfig
+++ b/drivers/gpu/drm/fsl-dcu/Kconfig
@@ -3,6 +3,7 @@ config DRM_FSL_DCU
tristate "DRM Support for Freescale DCU"
depends on DRM && OF && ARM && COMMON_CLK
select BACKLIGHT_CLASS_DEVICE
+ select DRM_GEM_CMA_HELPER
select DRM_KMS_HELPER
select DRM_PANEL
select REGMAP_MMIO
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] drm: aspeed: select CONFIG_DRM_GEM_CMA_HELPER
2021-12-04 17:46 [PATCH 1/2] drm: fsl-dcu: select CONFIG_DRM_GEM_CMA_HELPER Arnd Bergmann
@ 2021-12-04 17:46 ` Arnd Bergmann
2021-12-06 8:37 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2021-12-04 17:46 UTC (permalink / raw)
To: Joel Stanley, David Airlie, Daniel Vetter, Thomas Zimmermann
Cc: Arnd Bergmann, Andrew Jeffery, linux-aspeed, dri-devel,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The aspeed driver uses the gem_cma_helper code, but does
noto enforce enabling this through Kconfig:
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2c8): undefined reference to `drm_gem_cma_prime_import_sg_table'
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2d8): undefined reference to `drm_gem_cma_dumb_create'
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_crtc.o: in function `aspeed_gfx_pipe_update':
aspeed_gfx_crtc.c:(.text+0xe5): undefined reference to `drm_fb_cma_get_gem_obj'
Add the same 'select' that is used in other such drivers.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/aspeed/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig
index 36c4a7e86981..024ccab14f88 100644
--- a/drivers/gpu/drm/aspeed/Kconfig
+++ b/drivers/gpu/drm/aspeed/Kconfig
@@ -5,6 +5,7 @@ config DRM_ASPEED_GFX
depends on (COMPILE_TEST || ARCH_ASPEED)
depends on MMU
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
select DMA_CMA if HAVE_DMA_CONTIGUOUS
select CMA if HAVE_DMA_CONTIGUOUS
select MFD_SYSCON
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] drm: aspeed: select CONFIG_DRM_GEM_CMA_HELPER
2021-12-04 17:46 ` [PATCH 2/2] drm: aspeed: " Arnd Bergmann
@ 2021-12-06 8:37 ` Thomas Zimmermann
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2021-12-06 8:37 UTC (permalink / raw)
To: Arnd Bergmann, Joel Stanley, David Airlie, Daniel Vetter
Cc: Arnd Bergmann, Andrew Jeffery, linux-aspeed, dri-devel,
linux-arm-kernel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1110 bytes --]
Hi Arnd
Am 04.12.21 um 18:46 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The aspeed driver uses the gem_cma_helper code, but does
> noto enforce enabling this through Kconfig:
>
> x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2c8): undefined reference to `drm_gem_cma_prime_import_sg_table'
> x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2d8): undefined reference to `drm_gem_cma_dumb_create'
> x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_crtc.o: in function `aspeed_gfx_pipe_update':
> aspeed_gfx_crtc.c:(.text+0xe5): undefined reference to `drm_fb_cma_get_gem_obj'
>
> Add the same 'select' that is used in other such drivers.
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks! I've added both patches to drm-misc-next.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-06 8:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-04 17:46 [PATCH 1/2] drm: fsl-dcu: select CONFIG_DRM_GEM_CMA_HELPER Arnd Bergmann
2021-12-04 17:46 ` [PATCH 2/2] drm: aspeed: " Arnd Bergmann
2021-12-06 8:37 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).