* [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
@ 2023-10-12 6:11 Abel Vesa
2023-10-12 6:36 ` Satya Durga Srinivasu Prabhala
2023-10-12 8:23 ` Konrad Dybcio
0 siblings, 2 replies; 3+ messages in thread
From: Abel Vesa @ 2023-10-12 6:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, Linux Kernel Mailing List, Avinash Philip,
Umnathi Chalicheemala
According to documentation, it has increments of 4, not 8.
Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
drivers/soc/qcom/llcc-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 674abd0d6700..fb4085b7cb19 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -47,7 +47,7 @@
#define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
#define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
#define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
-#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
+#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)
#define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
#define LLCC_TRP_PCB_ACT 0x21f04
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
2023-10-12 6:11 [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset Abel Vesa
@ 2023-10-12 6:36 ` Satya Durga Srinivasu Prabhala
2023-10-12 8:23 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Satya Durga Srinivasu Prabhala @ 2023-10-12 6:36 UTC (permalink / raw)
To: Abel Vesa, Andy Gross, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, Linux Kernel Mailing List, Avinash Philip,
Umnathi Chalicheemala
On 10/11/2023 11:11 PM, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Thanks Abel.
Reviewed-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
> ---
> drivers/soc/qcom/llcc-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 674abd0d6700..fb4085b7cb19 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -47,7 +47,7 @@
> #define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
> #define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
> #define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
> -#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
> +#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)
>
> #define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
> #define LLCC_TRP_PCB_ACT 0x21f04
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
2023-10-12 6:11 [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset Abel Vesa
2023-10-12 6:36 ` Satya Durga Srinivasu Prabhala
@ 2023-10-12 8:23 ` Konrad Dybcio
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-10-12 8:23 UTC (permalink / raw)
To: Abel Vesa, Andy Gross, Bjorn Andersson
Cc: linux-arm-msm, Linux Kernel Mailing List, Avinash Philip,
Umnathi Chalicheemala
On 10/12/23 08:11, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 6:11 [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset Abel Vesa
2023-10-12 6:36 ` Satya Durga Srinivasu Prabhala
2023-10-12 8:23 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).