* [PATCH][next] iio: dac: ad5770r: fix off-by-one check on maximum number of channels
@ 2020-04-03 12:58 Colin King
2020-04-03 13:26 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2020-04-03 12:58 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Mircea Caprioru, Alexandru Tachici, linux-iio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently there is an off-by-one check on the number of channels that
will cause an arry overrun in array st->output_mode when calling the
function d5770r_store_output_range. Fix this by using >= rather than >
to check for maximum number of channels.
Addresses-Coverity: ("Out-of-bounds access")
Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/iio/dac/ad5770r.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
index a98ea76732e7..2d7623b9b2c0 100644
--- a/drivers/iio/dac/ad5770r.c
+++ b/drivers/iio/dac/ad5770r.c
@@ -525,7 +525,7 @@ static int ad5770r_channel_config(struct ad5770r_state *st)
ret = fwnode_property_read_u32(child, "num", &num);
if (ret)
return ret;
- if (num > AD5770R_MAX_CHANNELS)
+ if (num >= AD5770R_MAX_CHANNELS)
return -EINVAL;
ret = fwnode_property_read_u32_array(child,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] iio: dac: ad5770r: fix off-by-one check on maximum number of channels
2020-04-03 12:58 [PATCH][next] iio: dac: ad5770r: fix off-by-one check on maximum number of channels Colin King
@ 2020-04-03 13:26 ` Ardelean, Alexandru
2020-04-05 11:59 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2020-04-03 13:26 UTC (permalink / raw)
To: stefan.popa, Tachici, Alexandru, Caprioru, Mircea, linux-iio,
jic23, colin.king, Hennerich, Michael, lars, knaack.h, pmeerw
Cc: kernel-janitors, linux-kernel
On Fri, 2020-04-03 at 13:58 +0100, Colin King wrote:
> [External]
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is an off-by-one check on the number of channels that
> will cause an arry overrun in array st->output_mode when calling the
> function d5770r_store_output_range. Fix this by using >= rather than >
> to check for maximum number of channels.
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Addresses-Coverity: ("Out-of-bounds access")
> Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/iio/dac/ad5770r.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
> index a98ea76732e7..2d7623b9b2c0 100644
> --- a/drivers/iio/dac/ad5770r.c
> +++ b/drivers/iio/dac/ad5770r.c
> @@ -525,7 +525,7 @@ static int ad5770r_channel_config(struct ad5770r_state
> *st)
> ret = fwnode_property_read_u32(child, "num", &num);
> if (ret)
> return ret;
> - if (num > AD5770R_MAX_CHANNELS)
> + if (num >= AD5770R_MAX_CHANNELS)
> return -EINVAL;
>
> ret = fwnode_property_read_u32_array(child,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] iio: dac: ad5770r: fix off-by-one check on maximum number of channels
2020-04-03 13:26 ` Ardelean, Alexandru
@ 2020-04-05 11:59 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-04-05 11:59 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: stefan.popa, Tachici, Alexandru, Caprioru, Mircea, linux-iio,
colin.king, Hennerich, Michael, lars, knaack.h, pmeerw,
kernel-janitors, linux-kernel
On Fri, 3 Apr 2020 13:26:00 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Fri, 2020-04-03 at 13:58 +0100, Colin King wrote:
> > [External]
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently there is an off-by-one check on the number of channels that
> > will cause an arry overrun in array st->output_mode when calling the
> > function d5770r_store_output_range. Fix this by using >= rather than >
> > to check for maximum number of channels.
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> > Addresses-Coverity: ("Out-of-bounds access")
> > Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to the fixes-togreg branch of iio.git.
thanks
Jonathan
> > ---
> > drivers/iio/dac/ad5770r.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
> > index a98ea76732e7..2d7623b9b2c0 100644
> > --- a/drivers/iio/dac/ad5770r.c
> > +++ b/drivers/iio/dac/ad5770r.c
> > @@ -525,7 +525,7 @@ static int ad5770r_channel_config(struct ad5770r_state
> > *st)
> > ret = fwnode_property_read_u32(child, "num", &num);
> > if (ret)
> > return ret;
> > - if (num > AD5770R_MAX_CHANNELS)
> > + if (num >= AD5770R_MAX_CHANNELS)
> > return -EINVAL;
> >
> > ret = fwnode_property_read_u32_array(child,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-05 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 12:58 [PATCH][next] iio: dac: ad5770r: fix off-by-one check on maximum number of channels Colin King
2020-04-03 13:26 ` Ardelean, Alexandru
2020-04-05 11:59 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).