From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting
Date: Fri, 19 Mar 2021 17:08:47 +0100 [thread overview]
Message-ID: <84861de0-a672-03de-3dc2-c14605a1fff2@pengutronix.de> (raw)
In-Reply-To: <CAHp75Ves0+oebnSSYNNb=DcAuiN6-BFwp4jyDD9pSeg6FX2HKg@mail.gmail.com>
Hello Andy,
On 19.03.21 13:16, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 1:46 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>> On 19.03.21 12:13, Andy Shevchenko wrote:
>>> On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>>>>
>>>> We now have three places within the same file doing the same operation
>>>> of freeing this pointer and setting it anew. A helper make this
>>>
>>> makes
>>>
>>>> arguably easier to read, so add one.
>>>
>>> FWIW,
>>> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
>> Thanks will add for v3.
>>
>>> Now I'm wondering why deferred_probe_reason is not defined with const.
>>>
>>> Can you check and maybe squeeze a patch in the middle (before these
>>> two of this series) to move to const?
>>
>> The deferred_probe_reason is only used in this file and it either holds
>> NULL or a pointer to a dynamically allocated string. I don't see a reason
>> why the member should be const.
>
> But we want to be reliant on the contents of the string, right?
> I would put this why it shouldn't be const.
>
> As far as I understand the strictness here is for good.
I don't understand. Mind sending a patch that I can squash?
Cheers,
Ahmad
>
> --
> With Best Regards,
> Andy Shevchenko
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-03-19 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210319110516eucas1p1d4e5152af8a1873f192f4edba8cfbb8f@eucas1p1.samsung.com>
2021-03-19 11:04 ` [PATCH v2 1/2] driver core: clear deferred probe reason on probe retry Ahmad Fatoum
2021-03-19 11:04 ` [PATCH v2 2/2] driver core: add helper for deferred probe reason setting Ahmad Fatoum
2021-03-19 11:13 ` Andy Shevchenko
2021-03-19 11:46 ` Ahmad Fatoum
2021-03-19 12:16 ` Andy Shevchenko
2021-03-19 16:08 ` Ahmad Fatoum [this message]
2021-03-19 11:15 ` Andy Shevchenko
2021-03-19 11:47 ` Ahmad Fatoum
2021-03-23 14:07 ` Greg Kroah-Hartman
2021-03-23 15:27 ` Ahmad Fatoum
2021-03-22 8:18 ` [PATCH v2 1/2] driver core: clear deferred probe reason on probe retry Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84861de0-a672-03de-3dc2-c14605a1fff2@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).