linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Robert R. Howell" <RHowell@uwyo.edu>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Hans De Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2 1/5] PM: ACPI/PCI: Resume all devices during hibernation
Date: Tue, 2 Jul 2019 04:24:01 +0000	[thread overview]
Message-ID: <848e9c1b-7775-58bf-ac12-a8618b526876@uwyo.edu> (raw)
In-Reply-To: <6191578.xJk2HsE5MX@kreacher>

On 7/1/19 4:44 AM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Both the PCI bus type and the ACPI PM domain avoid resuming
> runtime-suspended devices with DPM_FLAG_SMART_SUSPEND set during
> hibernation (before creating the snapshot image of system memory),
> but that turns out to be a mistake.  It leads to functional issues
> and adds complexity that's hard to justify.
> 
> For this reason, resume all runtime-suspended PCI devices and all
> devices in the ACPI PM domains before creating a snapshot image of
> system memory during hibernation.
> 
> Fixes: 05087360fd7a (ACPI / PM: Take SMART_SUSPEND driver flag into account)
> Fixes: c4b65157aeef (PCI / PM: Take SMART_SUSPEND driver flag into account)
> Link: https://lore.kernel.org/linux-acpi/917d4399-2e22-67b1-9d54-808561f9083f@uwyo.edu/T/#maf065fe6e4974f2a9d79f332ab99dfaba635f64c
> Reported-by: Robert R. Howell <RHowell@uwyo.edu>
> Tested-by: Robert R. Howell <RHowell@uwyo.edu>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> 
> -> v2: No changes.

I've tested your v2 patch set on my ASUS T100TA, applying just those 5 patches to the 
5.2-rc7 kernel, and they do fix the hibernation problem.  The i2c_designware 
timeout errors are now gone and sound does now work after resume from both 
suspend and hibernate.  

As before I still see the "i2c_designware 80860F41:00: Transfer while suspended" error 
on the first resume from either suspend or hibernate, but also as before that 
particular error doesn't seem to cause a persistent problem and the system works 
normally after the resume.

Bob Howell

  parent reply	other threads:[~2019-07-02  4:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 10:42 [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes Rafael J. Wysocki
2019-07-01 10:44 ` [PATCH v2 1/5] PM: ACPI/PCI: Resume all devices during hibernation Rafael J. Wysocki
2019-07-01 16:15   ` Mika Westerberg
2019-07-02 15:59     ` Rafael J. Wysocki
2019-07-02  4:24   ` Robert R. Howell [this message]
2019-07-01 10:46 ` [PATCH v2 2/5] PCI: PM: Simplify bus-level hibernation callbacks Rafael J. Wysocki
2019-07-01 10:54 ` [PATCH v2 3/5] ACPI: PM: Simplify and fix PM domain " Rafael J. Wysocki
2019-07-01 10:54 ` [PATCH v2 4/5] ACPI: PM: Introduce "poweroff" callbacks for ACPI PM domain and LPSS Rafael J. Wysocki
2019-07-01 10:55 ` [PATCH v2 5/5] ACPI: PM: Drop unused function and function header Rafael J. Wysocki
2019-07-01 11:30 ` [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes Hans de Goede
2019-07-01 16:20 ` Mika Westerberg
2019-07-05  9:50   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=848e9c1b-7775-58bf-ac12-a8618b526876@uwyo.edu \
    --to=rhowell@uwyo.edu \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=helgaas@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --subject='Re: [PATCH v2 1/5] PM: ACPI/PCI: Resume all devices during hibernation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).