linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>
Cc: Linux PCI <linux-pci@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Robert R. Howell" <RHowell@uwyo.edu>
Subject: Re: [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes
Date: Mon, 1 Jul 2019 13:30:25 +0200	[thread overview]
Message-ID: <fc53d965-c5b6-45b9-8e0d-1de2fbed09a8@redhat.com> (raw)
In-Reply-To: <4976412.ihyb9sT5jY@kreacher>

Hi Rafael,

On 01-07-19 12:42, Rafael J. Wysocki wrote:
> Hi All,
> 
> This series of patches addresses a few issues related to the handling of
> hibernation in the PCI bus type and the ACPI PM domain and ACPI LPSS driver.
> 
> The v2 addresses Hans' concerns regarding the LPSS changes.
> 
> First of all, all of the runtime-suspended PCI devices and devices in the ACPI PM and LPSS
> PM domains will be resumed during hibernation (first patch).  This appears to be the
> only way to avoid weird corner cases and the benefit from avoiding to resume those
> devices during hibernation is questionable.
> 
> That change allows the the hibernation callbacks in all of the involved subsystems to be
> simplified (patches 2 and 3).
> 
> Moreover, reusing bus-level suspend callbacks for the "poweroff" transition during
> hibernation (which is the case for the ACPI PM domain and LPSS) is incorrect, so patch 4
> fixes that.
> 
> Finally, there are some leftover items in linux/acpi.h that can be dropped (patch 5).

Thank you for the new version, the entire series looks good to me now:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

p.s.

FWIW I agree that the calling of the suspend_late method of the i2c-designware driver
at suspend_noirq time is ugly, thank you for adding the comment documenting this.

  parent reply	other threads:[~2019-07-01 11:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-01 10:42 Rafael J. Wysocki
2019-07-01 10:44 ` [PATCH v2 1/5] PM: ACPI/PCI: Resume all devices during hibernation Rafael J. Wysocki
2019-07-01 16:15   ` Mika Westerberg
2019-07-02 15:59     ` Rafael J. Wysocki
2019-07-02  4:24   ` Robert R. Howell
2019-07-01 10:46 ` [PATCH v2 2/5] PCI: PM: Simplify bus-level hibernation callbacks Rafael J. Wysocki
2019-07-01 10:54 ` [PATCH v2 3/5] ACPI: PM: Simplify and fix PM domain " Rafael J. Wysocki
2019-07-01 10:54 ` [PATCH v2 4/5] ACPI: PM: Introduce "poweroff" callbacks for ACPI PM domain and LPSS Rafael J. Wysocki
2019-07-01 10:55 ` [PATCH v2 5/5] ACPI: PM: Drop unused function and function header Rafael J. Wysocki
2019-07-01 11:30 ` Hans de Goede [this message]
2019-07-01 16:20 ` [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes Mika Westerberg
2019-07-05  9:50   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc53d965-c5b6-45b9-8e0d-1de2fbed09a8@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=RHowell@uwyo.edu \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=helgaas@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --subject='Re: [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).