From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jingbao Qiu <qiujingbao.dlmu@gmail.com>,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
krzysztof.kozlowski+dt@linaro.org, chao.wei@sophgo.com,
unicorn_wang@outlook.com, conor+dt@kernel.org,
robh+dt@kernel.org, conor@kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rtc: add binding for Sophgo CV1800B rtc controller
Date: Tue, 21 Nov 2023 10:57:46 +0100 [thread overview]
Message-ID: <84a12a2c-3f64-4517-8d38-14c8516e70d0@linaro.org> (raw)
In-Reply-To: <20231121094642.2973795-2-qiujingbao.dlmu@gmail.com>
On 21/11/2023 10:46, Jingbao Qiu wrote:
> Add devicetree binding for Sophgo CV1800B SoC rtc controller.
A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
>
> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> ---
> .../bindings/rtc/sophgo,cv1800b-rtc.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> new file mode 100644
> index 000000000000..fefb1e70c45c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo CV1800B SoC RTC Controller
What is a RTC Controller? You have multiple RTCs there?
> +
> +maintainers:
> + - Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> +
Missing ref to rtc.yaml. Unless it is not applicable but then why?
> +properties:
> + compatible:
> + enum:
> + - sophgo,cv1800b-rtc
Blank line
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
unevaluatedProperties instead
> +
> +examples:
> + - |
> + rtc-controller@05026000{
The names is always "rtc", unless this is not RTC. If it isn't, please
add full description of the hardware.
> + compatible = "sophgo,cv800b-rtc";
> + reg = <0x05026000 0x1000>;
> + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-parent = <&plic0>;
> + clocks = <&osc>;
Why do you send untested bindings? Review costs significant amount of
effort. Code was also not compiled? Warnings not fixed?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-21 9:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 9:46 [PATCH 0/3] riscv: sophgo: add rtc support for CV1800B Jingbao Qiu
2023-11-21 9:46 ` [PATCH 1/3] dt-bindings: rtc: add binding for Sophgo CV1800B rtc controller Jingbao Qiu
2023-11-21 9:57 ` Krzysztof Kozlowski [this message]
2023-11-28 13:20 ` jingbao qiu
2023-11-21 10:37 ` Rob Herring
2023-11-21 9:46 ` [PATCH 2/3] rtc: add rtc controller support for Sophgo CV1800B SoC Jingbao Qiu
2023-11-21 10:01 ` Krzysztof Kozlowski
2023-11-28 13:22 ` jingbao qiu
2023-11-28 13:59 ` Krzysztof Kozlowski
2023-11-28 14:34 ` jingbao qiu
2023-11-28 23:01 ` Alexandre Belloni
2023-11-21 17:58 ` kernel test robot
2023-11-21 22:52 ` kernel test robot
2023-11-21 9:46 ` [PATCH 3/3] riscv: dts: sophgo: add rtc dt node for CV1800B Jingbao Qiu
2023-11-21 10:00 ` Krzysztof Kozlowski
2023-11-28 13:23 ` jingbao qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84a12a2c-3f64-4517-8d38-14c8516e70d0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).