* [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER
@ 2021-09-27 9:36 Arnd Bergmann
2021-09-27 11:04 ` Mikko Perttunen
2021-10-07 18:03 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-09-27 9:36 UTC (permalink / raw)
To: Thierry Reding, Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Linking fails when dma-buf is disabled:
ld.lld: error: undefined symbol: dma_fence_release
>>> referenced by fence.c
>>> gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
>>> referenced by fence.c
>>> gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
>>> referenced by fence.c
>>> gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a
Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/host1x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 6dab94adf25e..6815b4db17c1 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -2,6 +2,7 @@
config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+ select DMA_SHARED_BUFFER
select IOMMU_IOVA
help
Driver for the NVIDIA Tegra host1x hardware.
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER
2021-09-27 9:36 [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER Arnd Bergmann
@ 2021-09-27 11:04 ` Mikko Perttunen
2021-10-07 18:03 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Mikko Perttunen @ 2021-09-27 11:04 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
On 9/27/21 12:36 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Linking fails when dma-buf is disabled:
>
> ld.lld: error: undefined symbol: dma_fence_release
>>>> referenced by fence.c
>>>> gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
>>>> referenced by fence.c
>>>> gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
>>>> referenced by fence.c
>>>> gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a
>
> Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94adf25e..6815b4db17c1 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -2,6 +2,7 @@
> config TEGRA_HOST1X
> tristate "NVIDIA Tegra host1x driver"
> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> + select DMA_SHARED_BUFFER
> select IOMMU_IOVA
> help
> Driver for the NVIDIA Tegra host1x hardware.
>
Thanks!
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER
2021-09-27 9:36 [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER Arnd Bergmann
2021-09-27 11:04 ` Mikko Perttunen
@ 2021-10-07 18:03 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-10-07 18:03 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mikko Perttunen, Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
On Mon, Sep 27, 2021 at 11:36:59AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Linking fails when dma-buf is disabled:
>
> ld.lld: error: undefined symbol: dma_fence_release
> >>> referenced by fence.c
> >>> gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
> >>> referenced by fence.c
> >>> gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
> >>> referenced by fence.c
> >>> gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a
>
> Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/host1x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-07 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 9:36 [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER Arnd Bergmann
2021-09-27 11:04 ` Mikko Perttunen
2021-10-07 18:03 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).