From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Geert Uytterhoeven <geert+renesas@glider.be>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-power@fi.rohmeurope.com, linux-watchdog@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH v8 6/6] mfd: bd9576: Add safety limit/monitoring registers
Date: Mon, 08 Mar 2021 17:09:45 +0200 [thread overview]
Message-ID: <84b54b6c741fec920f26fc47890da40bf25cae49.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20210308134716.GF4931@dell>
On Mon, 2021-03-08 at 13:47 +0000, Lee Jones wrote:
> On Thu, 11 Feb 2021, Matti Vaittinen wrote:
>
> > ROHM BD9576 contains safety features like over/under voltage
> > detection,
> > over curren detection and over temperature detection. Add the
> > configuration register information.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >
> > Changes since v7:
> > New patch
> >
> > include/linux/mfd/rohm-bd957x.h | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/include/linux/mfd/rohm-bd957x.h
> > b/include/linux/mfd/rohm-bd957x.h
> > index 3f351a1ae4ab..2bd35260ee8e 100644
> > --- a/include/linux/mfd/rohm-bd957x.h
> > +++ b/include/linux/mfd/rohm-bd957x.h
> > @@ -116,6 +116,25 @@ enum {
> > #define BD957X_REG_VOUT4_TUNE 0x59
> > #define BD957X_REG_VOUTL1_TUNE 0x5c
> >
> > +#define BD9576_REG_VOUT1_OVD 0x51
> > +#define BD9576_REG_VOUT1_UVD 0x52
> > +#define BD9576_REG_VOUT2_OVD 0x54
> > +#define BD9576_REG_VOUT2_UVD 0x55
> > +#define BD9576_REG_VOUT3_OVD 0x57
> > +#define BD9576_REG_VOUT3_UVD 0x58
> > +#define BD9576_REG_VOUT4_OVD 0x5a
> > +#define BD9576_REG_VOUT4_UVD 0x5b
> > +#define BD9576_REG_VOUTL1_OVD 0x5d
> > +#define BD9576_REG_VOUTL1_UVD 0x5e
> > +
> > +#define BD9576_MASK_XVD 0x7f
> > +
> > +#define BD9576_REG_VOUT1S_OCW 0x5f
> > +#define BD9576_REG_VOUT1S_OCP 0x60
> > +
> > +#define BD9576_MASK_VOUT1S_OCW 0x3f
> > +#define BD9576_MASK_VOUT1S_OCP 0x3f
>
> Just a quick check, are these meant to be the same value?
Thanks for the check. They are both same value.
>
> If so:
>
> For my own reference (apply this as-is to your sign-off block):
>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>
Thanks, I'll add your ack.
Best Regards
Matti
prev parent reply other threads:[~2021-03-08 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 9:46 [PATCH v8 0/6] Support ROHM BD9576MUF and BD9573MUF PMICs Matti Vaittinen
2021-02-11 9:47 ` [PATCH v8 1/6] dt_bindings: mfd: Add " Matti Vaittinen
2021-02-11 9:48 ` [PATCH v8 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF Matti Vaittinen
2021-03-08 13:36 ` Lee Jones
2021-03-08 14:52 ` Matti Vaittinen
2021-02-11 9:48 ` [PATCH v8 3/6] mfd: bd9576: Add IRQ support Matti Vaittinen
2021-03-08 13:44 ` Lee Jones
2021-02-11 9:49 ` [PATCH v8 4/6] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF Matti Vaittinen
2021-02-11 9:49 ` [PATCH v8 5/6] MAINTAINERS: Add ROHM BD9576MUF and BD9573MUF drivers Matti Vaittinen
2021-02-11 9:50 ` [PATCH v8 6/6] mfd: bd9576: Add safety limit/monitoring registers Matti Vaittinen
2021-03-08 13:47 ` Lee Jones
2021-03-08 15:09 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b54b6c741fec920f26fc47890da40bf25cae49.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).