linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] DTS changes for the AMD EthanolX CRB BMC
@ 2022-06-11  9:58 Konstantin Aladyshev
  2022-06-11  9:58 ` [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device Konstantin Aladyshev
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Konstantin Aladyshev @ 2022-06-11  9:58 UTC (permalink / raw)
  Cc: supreeth.venkatesh, aladyshev22, Rob Herring,
	Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel

Several patches for the DTS of the BMC on the AMD EthanolX CRB.

Konstantin Aladyshev (4):
  ARM: dts: aspeed: ethanolx: Add correct label to flash device
  ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1
  ARM: dts: aspeed: ethanolx: Use correct driver for the FRU EEPROM
  ARM: dts: aspeed: ethanolx: Enable VUART

 arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device
  2022-06-11  9:58 [PATCH 0/4] DTS changes for the AMD EthanolX CRB BMC Konstantin Aladyshev
@ 2022-06-11  9:58 ` Konstantin Aladyshev
  2022-07-21  2:31   ` Andrew Jeffery
  2022-06-11  9:58 ` [PATCH 2/4] ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1 Konstantin Aladyshev
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Konstantin Aladyshev @ 2022-06-11  9:58 UTC (permalink / raw)
  Cc: supreeth.venkatesh, aladyshev22, Rob Herring,
	Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel

The OpenBMC code update infrastructure requires BMC firmware flash
drive to have a label "bmc".

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
index 6406a0f080ee..889b2fdd19cf 100644
--- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
@@ -58,6 +58,7 @@ &fmc {
 	flash@0 {
 		status = "okay";
 		m25p,fast-read;
+		label = "bmc";
 		#include "openbmc-flash-layout.dtsi"
 	};
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/4] ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1
  2022-06-11  9:58 [PATCH 0/4] DTS changes for the AMD EthanolX CRB BMC Konstantin Aladyshev
  2022-06-11  9:58 ` [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device Konstantin Aladyshev
@ 2022-06-11  9:58 ` Konstantin Aladyshev
  2022-07-21  2:32   ` Andrew Jeffery
  2022-06-11  9:58 ` [PATCH 3/4] ARM: dts: aspeed: ethanolx: Use correct driver for the FRU EEPROM Konstantin Aladyshev
  2022-06-11  9:58 ` [PATCH 4/4] ARM: dts: aspeed: ethanolx: Enable VUART Konstantin Aladyshev
  3 siblings, 1 reply; 8+ messages in thread
From: Konstantin Aladyshev @ 2022-06-11  9:58 UTC (permalink / raw)
  Cc: supreeth.venkatesh, aladyshev22, Rob Herring,
	Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel

UART1 is used for connection to the main EPYC CPU. Besides the main
TX/RX signals this connection has flow control signals RTS/CTS,
therefore configure this pins on the BMC side.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
index 889b2fdd19cf..0354a7d8f9f5 100644
--- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
@@ -79,7 +79,9 @@ &uart1 {
 	status = "okay";
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_txd1_default
-		     &pinctrl_rxd1_default>;
+		     &pinctrl_rxd1_default
+		     &pinctrl_nrts1_default
+		     &pinctrl_ncts1_default>;
 };
 
 &uart5 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/4] ARM: dts: aspeed: ethanolx: Use correct driver for the FRU EEPROM
  2022-06-11  9:58 [PATCH 0/4] DTS changes for the AMD EthanolX CRB BMC Konstantin Aladyshev
  2022-06-11  9:58 ` [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device Konstantin Aladyshev
  2022-06-11  9:58 ` [PATCH 2/4] ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1 Konstantin Aladyshev
@ 2022-06-11  9:58 ` Konstantin Aladyshev
  2022-06-11  9:58 ` [PATCH 4/4] ARM: dts: aspeed: ethanolx: Enable VUART Konstantin Aladyshev
  3 siblings, 0 replies; 8+ messages in thread
From: Konstantin Aladyshev @ 2022-06-11  9:58 UTC (permalink / raw)
  Cc: supreeth.venkatesh, aladyshev22, Rob Herring,
	Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel

The AMD EthanolX CRB uses 24LC128 chip as FRU EEPROM. To bind correct
driver for this device "24c128" compatible string should be used in DTS.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
index 0354a7d8f9f5..428fa9f673f9 100644
--- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
@@ -163,7 +163,7 @@ &i2c2 {
 &i2c3 {
 	status = "okay";
 	eeprom@50 {
-		compatible = "atmel,24c256";
+		compatible = "atmel,24c128";
 		reg = <0x50>;
 		pagesize = <64>;
 	};
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 4/4] ARM: dts: aspeed: ethanolx: Enable VUART
  2022-06-11  9:58 [PATCH 0/4] DTS changes for the AMD EthanolX CRB BMC Konstantin Aladyshev
                   ` (2 preceding siblings ...)
  2022-06-11  9:58 ` [PATCH 3/4] ARM: dts: aspeed: ethanolx: Use correct driver for the FRU EEPROM Konstantin Aladyshev
@ 2022-06-11  9:58 ` Konstantin Aladyshev
  2022-07-21  2:32   ` Andrew Jeffery
  3 siblings, 1 reply; 8+ messages in thread
From: Konstantin Aladyshev @ 2022-06-11  9:58 UTC (permalink / raw)
  Cc: supreeth.venkatesh, aladyshev22, Rob Herring,
	Krzysztof Kozlowski, Joel Stanley, Andrew Jeffery, devicetree,
	linux-arm-kernel, linux-aspeed, linux-kernel

Enable virtual UART for BMC<->Host communication.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
index 428fa9f673f9..90feac5ec628 100644
--- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
@@ -5,6 +5,7 @@
 
 #include "aspeed-g5.dtsi"
 #include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
 	model = "AMD EthanolX BMC";
@@ -264,6 +265,12 @@ &lpc_ctrl {
 	status = "okay";
 };
 
+&vuart {
+	status = "okay";
+	aspeed,lpc-io-reg = <0x3f8>;
+	aspeed,lpc-interrupts = <4 IRQ_TYPE_LEVEL_HIGH>;
+};
+
 &pwm_tacho {
 	status = "okay";
 	pinctrl-names = "default";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device
  2022-06-11  9:58 ` [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device Konstantin Aladyshev
@ 2022-07-21  2:31   ` Andrew Jeffery
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Jeffery @ 2022-07-21  2:31 UTC (permalink / raw)
  To: Konstantin Aladyshev
  Cc: Supreeth Venkatesh, Rob Herring, Krzysztof Kozlowski,
	Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed,
	linux-kernel



On Sat, 11 Jun 2022, at 19:28, Konstantin Aladyshev wrote:
> The OpenBMC code update infrastructure requires BMC firmware flash
> drive to have a label "bmc".
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

Acked-by: Andrew Jeffery <andrew@aj.id.au>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/4] ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1
  2022-06-11  9:58 ` [PATCH 2/4] ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1 Konstantin Aladyshev
@ 2022-07-21  2:32   ` Andrew Jeffery
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Jeffery @ 2022-07-21  2:32 UTC (permalink / raw)
  To: Konstantin Aladyshev
  Cc: Supreeth Venkatesh, Rob Herring, Krzysztof Kozlowski,
	Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed,
	linux-kernel



On Sat, 11 Jun 2022, at 19:28, Konstantin Aladyshev wrote:
> UART1 is used for connection to the main EPYC CPU. Besides the main
> TX/RX signals this connection has flow control signals RTS/CTS,
> therefore configure this pins on the BMC side.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

Acked-by: Andrew Jeffery <andrew@aj.id.au>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 4/4] ARM: dts: aspeed: ethanolx: Enable VUART
  2022-06-11  9:58 ` [PATCH 4/4] ARM: dts: aspeed: ethanolx: Enable VUART Konstantin Aladyshev
@ 2022-07-21  2:32   ` Andrew Jeffery
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Jeffery @ 2022-07-21  2:32 UTC (permalink / raw)
  To: Konstantin Aladyshev
  Cc: Supreeth Venkatesh, Rob Herring, Krzysztof Kozlowski,
	Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed,
	linux-kernel



On Sat, 11 Jun 2022, at 19:28, Konstantin Aladyshev wrote:
> Enable virtual UART for BMC<->Host communication.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

Acked-by: Andrew Jeffery <andrew@aj.id.au>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-07-21  2:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-11  9:58 [PATCH 0/4] DTS changes for the AMD EthanolX CRB BMC Konstantin Aladyshev
2022-06-11  9:58 ` [PATCH 1/4] ARM: dts: aspeed: ethanolx: Add correct label to flash device Konstantin Aladyshev
2022-07-21  2:31   ` Andrew Jeffery
2022-06-11  9:58 ` [PATCH 2/4] ARM: dts: aspeed: ethanolx: Configure RTS/CTS for UART1 Konstantin Aladyshev
2022-07-21  2:32   ` Andrew Jeffery
2022-06-11  9:58 ` [PATCH 3/4] ARM: dts: aspeed: ethanolx: Use correct driver for the FRU EEPROM Konstantin Aladyshev
2022-06-11  9:58 ` [PATCH 4/4] ARM: dts: aspeed: ethanolx: Enable VUART Konstantin Aladyshev
2022-07-21  2:32   ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).