From: Michael Walle <michael@walle.cc>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Saravana Kannan <saravanak@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] driver core: Fix device link device name collision
Date: Thu, 07 Jan 2021 10:19:28 +0100 [thread overview]
Message-ID: <85acc1d3523a3c6f88687d3491f83380@walle.cc> (raw)
In-Reply-To: <X/bNxMPWKq2nbqS4@kroah.com>
Am 2021-01-07 10:00, schrieb Greg Kroah-Hartman:
> On Wed, Jan 06, 2021 at 03:26:41PM -0800, Saravana Kannan wrote:
>> The device link device's name was of the form:
>> <supplier-dev-name>--<consumer-dev-name>
>>
>> This can cause name collision as reported here [1] as device names are
>> not globally unique. Since device names have to be unique within the
>> bus/class, add the bus/class name as a prefix to the device names used
>> to
>> construct the device link device name.
>>
>> So the devuce link device's name will be of the form:
>> <supplier-bus-name>:<supplier-dev-name>--<consumer-bus-name><consumer-dev-name>
>
> Minor nit, you forgot a ':' in the consumer side of the link here. The
> code is correct.
>
>>
>> [1] -
>> https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/
>> Reported-by: Michael Walle <michael@walle.cc>
>> Signed-off-by: Saravana Kannan <saravanak@google.com>
>> ---
>>
>> Michael,
>>
>> Can you please test this? This should fix your issue.
>>
>> Having said that, do you have some local DT changes when you are
>> testing
>> this? Because it's not obvious from the DT in upstream what dependency
>> is even being derived from the firmware. I don't see any dependency in
>> upstream DT files between mdio_bus/0000:00:00.1 and
>> pci0000:00/0000:00:00.1
>
> That looks really odd, why is the mdio bus using the same names as the
> pci bus?
Logically the MDIO bus belongs to the ENETC, although its actually an
own
PCI device [1]. What do you think its name should be?
> But anyway, your dev_bus_name() change here looks good, I'll take that
> as a separate patch no matter what happens here :)
I'm just testing this patch, looks like it doesn't fix it for now. But
anyways. Shouldn't there be a Fixes tag for this patch? I.e. 5.11 is
broken right now.
[1]
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/enetc/enetc_pf.c#L748
-michael
next prev parent reply other threads:[~2021-01-07 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 23:26 [PATCH v1] driver core: Fix device link device name collision Saravana Kannan
2021-01-07 9:00 ` Greg Kroah-Hartman
2021-01-07 9:19 ` Michael Walle [this message]
2021-01-07 23:17 ` Saravana Kannan
2021-01-07 23:19 ` Saravana Kannan
2021-01-07 9:56 ` Michael Walle
2021-01-07 23:39 ` Saravana Kannan
2021-01-08 0:22 ` Michael Walle
2021-01-08 1:19 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85acc1d3523a3c6f88687d3491f83380@walle.cc \
--to=michael@walle.cc \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).