From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <huobean@gmail.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
asutoshd@codeaurora.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc
Date: Thu, 28 May 2020 07:56:14 -0700 [thread overview]
Message-ID: <85bbc91f-7b91-46fc-acff-3bcc2288c4ae@acm.org> (raw)
In-Reply-To: <20200528115616.9949-2-huobean@gmail.com>
On 2020-05-28 04:56, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> For the UFS device, the maximum descriptor size is 255, max_t called in
> ufs_get_device_desc() is useless.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index aca50ed39844..0f8c7e05df29 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6881,8 +6881,7 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
> u8 *desc_buf;
> struct ufs_dev_info *dev_info = &hba->dev_info;
>
> - buff_len = max_t(size_t, hba->desc_size.dev_desc,
> - QUERY_DESC_MAX_SIZE + 1);
> + buff_len = QUERY_DESC_MAX_SIZE + 1;
> desc_buf = kmalloc(buff_len, GFP_KERNEL);
> if (!desc_buf) {
> err = -ENOMEM;
Since the buff_len variable is not changed after its initial assignment,
please remove it entirely.
Thanks,
Bart.
next prev parent reply other threads:[~2020-05-28 14:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 11:56 [PATCH v2 0/3] scsi: ufs: cleanup ufs initialization Bean Huo
2020-05-28 11:56 ` [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc Bean Huo
2020-05-28 13:41 ` Avri Altman
2020-05-28 13:47 ` Bean Huo
2020-05-28 14:56 ` Bart Van Assche [this message]
2020-05-28 15:04 ` Bean Huo
2020-05-28 16:16 ` Bart Van Assche
2020-05-28 11:56 ` [PATCH v2 2/3] scsi: ufs: delete ufshcd_read_desc() Bean Huo
2020-05-28 13:47 ` Avri Altman
2020-05-28 14:59 ` Bart Van Assche
2020-05-29 1:12 ` Stanley Chu
2020-05-28 11:56 ` [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path Bean Huo
2020-05-28 14:58 ` Avri Altman
2020-05-28 16:03 ` Bean Huo
2020-05-28 16:18 ` Bart Van Assche
2020-05-28 15:04 ` Bart Van Assche
2020-05-29 1:26 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85bbc91f-7b91-46fc-acff-3bcc2288c4ae@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).