linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Bean Huo <huobean@gmail.com>,
	alim.akhtar@samsung.com, avri.altman@wdc.com,
	asutoshd@codeaurora.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, stanley.chu@mediatek.com,
	beanhuo@micron.com, tomas.winkler@intel.com, cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path
Date: Thu, 28 May 2020 08:04:09 -0700	[thread overview]
Message-ID: <dc54d52b-0687-9236-2e59-8a90465ec85b@acm.org> (raw)
In-Reply-To: <20200528115616.9949-4-huobean@gmail.com>

On 2020-05-28 04:56, Bean Huo wrote:
> At UFS initialization stage, to get the length of the descriptor,
> ufshcd_read_desc_length() being called 6 times. This patch is to
> delete unnecessary reduntant code, remove ufshcd_read_desc_length()
> and boost UFS initialization.

As explained in Documentation/process/submitting-patches.rst, please use
the imperative mood in patch descriptions. In other words, please change
"This patch is to delete" into "Delete". Please also change "reduntant"
into "redundant". Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart van Assche <bvanassche@acm.org>

  parent reply	other threads:[~2020-05-28 15:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 11:56 [PATCH v2 0/3] scsi: ufs: cleanup ufs initialization Bean Huo
2020-05-28 11:56 ` [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc Bean Huo
2020-05-28 13:41   ` Avri Altman
2020-05-28 13:47     ` Bean Huo
2020-05-28 14:56   ` Bart Van Assche
2020-05-28 15:04     ` Bean Huo
2020-05-28 16:16       ` Bart Van Assche
2020-05-28 11:56 ` [PATCH v2 2/3] scsi: ufs: delete ufshcd_read_desc() Bean Huo
2020-05-28 13:47   ` Avri Altman
2020-05-28 14:59   ` Bart Van Assche
2020-05-29  1:12   ` Stanley Chu
2020-05-28 11:56 ` [PATCH v2 3/3] scsi: ufs: cleanup ufs initialization path Bean Huo
2020-05-28 14:58   ` Avri Altman
2020-05-28 16:03     ` Bean Huo
2020-05-28 16:18     ` Bart Van Assche
2020-05-28 15:04   ` Bart Van Assche [this message]
2020-05-29  1:26   ` Stanley Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc54d52b-0687-9236-2e59-8a90465ec85b@acm.org \
    --to=bvanassche@acm.org \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).