* [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type
@ 2017-10-21 10:35 Dongjiu Geng
2017-10-21 12:15 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Dongjiu Geng @ 2017-10-21 10:35 UTC (permalink / raw)
To: rjw, lenb, tbaicar, will.deacon, bp, prarit, linux-acpi,
linux-kernel, gengdongjiu
For the SEA notification, the two functions ghes_sea_add() and
ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
is defined. If not, it will return errors in the ghes_probe()
and not continue. If the probe is failed, the ghes_sea_remove()
also has no chance to be called. Hence, remove the unnecessary
handling when CONFIG_ACPI_APEI_SEA is not defined.
For the NMI notification, it has the same issue as SEA notification,
so also remove the unused dead-code for it.
Cc: Tyler Baicar <tbaicar@codeaurora.org>
Cc: James Morse <james.morse@arm.com>
Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
---
drivers/acpi/apei/ghes.c | 33 +++++----------------------------
1 file changed, 5 insertions(+), 28 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d661d45..3eee30a 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -849,17 +849,8 @@ static void ghes_sea_remove(struct ghes *ghes)
synchronize_rcu();
}
#else /* CONFIG_ACPI_APEI_SEA */
-static inline void ghes_sea_add(struct ghes *ghes)
-{
- pr_err(GHES_PFX "ID: %d, trying to add SEA notification which is not supported\n",
- ghes->generic->header.source_id);
-}
-
-static inline void ghes_sea_remove(struct ghes *ghes)
-{
- pr_err(GHES_PFX "ID: %d, trying to remove SEA notification which is not supported\n",
- ghes->generic->header.source_id);
-}
+static inline void ghes_sea_add(struct ghes *ghes) { }
+static inline void ghes_sea_remove(struct ghes *ghes) { }
#endif /* CONFIG_ACPI_APEI_SEA */
#ifdef CONFIG_HAVE_ACPI_APEI_NMI
@@ -1061,23 +1052,9 @@ static void ghes_nmi_init_cxt(void)
init_irq_work(&ghes_proc_irq_work, ghes_proc_in_irq);
}
#else /* CONFIG_HAVE_ACPI_APEI_NMI */
-static inline void ghes_nmi_add(struct ghes *ghes)
-{
- pr_err(GHES_PFX "ID: %d, trying to add NMI notification which is not supported!\n",
- ghes->generic->header.source_id);
- BUG();
-}
-
-static inline void ghes_nmi_remove(struct ghes *ghes)
-{
- pr_err(GHES_PFX "ID: %d, trying to remove NMI notification which is not supported!\n",
- ghes->generic->header.source_id);
- BUG();
-}
-
-static inline void ghes_nmi_init_cxt(void)
-{
-}
+static inline void ghes_nmi_add(struct ghes *ghes) { }
+static inline void ghes_nmi_remove(struct ghes *ghes) { }
+static inline void ghes_nmi_init_cxt(void) { }
#endif /* CONFIG_HAVE_ACPI_APEI_NMI */
static int ghes_probe(struct platform_device *ghes_dev)
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type
2017-10-21 10:35 [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type Dongjiu Geng
@ 2017-10-21 12:15 ` Borislav Petkov
2017-10-22 6:13 ` gengdongjiu
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2017-10-21 12:15 UTC (permalink / raw)
To: Dongjiu Geng
Cc: rjw, lenb, tbaicar, will.deacon, prarit, linux-acpi, linux-kernel
On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
>
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
>
> Cc: Tyler Baicar <tbaicar@codeaurora.org>
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
> Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
I gave you Reviewed-by, not Signed-off-by.
Before you send more patches, read this:
Documentation/process/submitting-patches.rst
You can read the whole document but do especially concentrate on
sections 11-13, in order to get an idea how the SOB chain and all that
patch tagging works.
Thx.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type
2017-10-21 12:15 ` Borislav Petkov
@ 2017-10-22 6:13 ` gengdongjiu
0 siblings, 0 replies; 3+ messages in thread
From: gengdongjiu @ 2017-10-22 6:13 UTC (permalink / raw)
To: Borislav Petkov
Cc: rjw, lenb, tbaicar, will.deacon, prarit, linux-acpi, linux-kernel
On 2017/10/21 20:15, Borislav Petkov wrote:
>> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
>> Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
>> Signed-off-by: Borislav Petkov <bp@suse.de>
> I gave you Reviewed-by, not Signed-off-by.
>
> Before you send more patches, read this:
>
> Documentation/process/submitting-patches.rst
>
> You can read the whole document but do especially concentrate on
> sections 11-13, in order to get an idea how the SOB chain and all that
> patch tagging works.
Borislav,
Thanks a lot for your pointing out. sorry for that.
Just now I have read the "submitting-patches.rst". I will change it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-22 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-21 10:35 [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type Dongjiu Geng
2017-10-21 12:15 ` Borislav Petkov
2017-10-22 6:13 ` gengdongjiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).