From: Pierre Morel <pmorel@linux.ibm.com>
To: Tony Krowiak <akrowiak@linux.ibm.com>, borntraeger@de.ibm.com
Cc: alex.williamson@redhat.com, cohuck@redhat.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, frankja@linux.ibm.com, pasic@linux.ibm.com,
david@redhat.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, freude@linux.ibm.com,
mimu@linux.ibm.com
Subject: Re: [PATCH v4 6/7] s390: ap: Cleanup on removing the AP device
Date: Wed, 13 Mar 2019 11:15:20 +0100 [thread overview]
Message-ID: <85f772b4-0b62-701d-c3e5-e55e88c3fb4e@linux.ibm.com> (raw)
In-Reply-To: <cf148acb-1a07-ffa3-f728-0f6b02aa914d@linux.ibm.com>
On 12/03/2019 22:53, Tony Krowiak wrote:
> On 3/11/19 4:31 AM, Pierre Morel wrote:
>> On 08/03/2019 23:43, Tony Krowiak wrote:
>>> On 2/22/19 10:29 AM, Pierre Morel wrote:
>>>> When the device is remove, we must make sure to
>>>> clear the interruption and reset the AP device.
>>>>
>>>> We also need to clear the CRYCB of the guest.
>>>>
>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>> ---
>>>> drivers/s390/crypto/vfio_ap_drv.c | 35
>>>> +++++++++++++++++++++++++++++++++++
>>>> drivers/s390/crypto/vfio_ap_ops.c | 3 ++-
>>>> drivers/s390/crypto/vfio_ap_private.h | 3 +++
>>>> 3 files changed, 40 insertions(+), 1 deletion(-)
>>>>
...snip...
>>>> + * vfio_ap_update_crycb
>>>> + * @q: A pointer to the queue being removed
>>>> + *
>>>> + * We clear the APID of the queue, making this queue unusable for
>>>> the guest.
>>>> + * After this function we can reset the queue without to fear a
>>>> race with
>>>> + * the guest to access the queue again.
>>>> + * We do not fear race with the host as we still get the devic
>>>> + */
>>>> +static void vfio_ap_update_crycb(struct vfio_ap_queue *q)
>>>> +{
>>>> + struct ap_matrix_mdev *matrix_mdev = q->matrix_mdev;
>>>> +
>>>> + if (!matrix_mdev)
>>>> + return;
>>>> +
>
> You should probably check whether the APID has been cleared before
> proceeding. Take the case where an AP with multiple queues is removed
> from the configuration via the SE or SCLP. The AP bus is going to invoke
> the vfio_ap_queue_dev_remove() function for each of the queues. The APID
> will get cleared on the first remove, so it is not only unnecessary to
> clear it on subsequent removes, it is kind of nasty to keep resetting
> the masks in the guest's CRYCB (below) each time the remove callback is
> invoked.
This can not happen.
The only way to clear the APM is when the matrix is not associated with KVM.
This case is tested and the masks are not changed.
>
>>>> + clear_bit_inv(AP_QID_CARD(q->apqn), matrix_mdev->matrix.apm);
>>>> +
>>>> + if (!matrix_mdev->kvm)
>>>> + return;
>>>> +
>>>> + kvm_arch_crypto_set_masks(matrix_mdev->kvm,
>>>> + matrix_mdev->matrix.apm,
>>>> + matrix_mdev->matrix.aqm,
>>>> + matrix_mdev->matrix.adm);
>>>> +}
--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
next prev parent reply other threads:[~2019-03-13 10:15 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 15:29 [PATCH v4 0/7] vfio: ap: AP Queue Interrupt Control Pierre Morel
2019-02-22 15:29 ` [PATCH v4 1/7] s390: ap: kvm: add PQAP interception for AQIC Pierre Morel
2019-02-25 18:36 ` Tony Krowiak
2019-02-26 11:47 ` Pierre Morel
2019-02-26 15:47 ` Tony Krowiak
2019-02-27 8:09 ` Pierre Morel
2019-02-27 9:13 ` Cornelia Huck
2019-02-27 10:16 ` Pierre Morel
2019-02-27 18:00 ` Tony Krowiak
2019-02-28 9:42 ` Christian Borntraeger
2019-02-28 11:03 ` Christian Borntraeger
2019-02-28 11:22 ` Cornelia Huck
2019-02-28 13:16 ` Pierre Morel
2019-02-28 13:52 ` Cornelia Huck
2019-02-28 14:14 ` Pierre Morel
2019-03-01 12:03 ` Pierre Morel
2019-03-01 12:05 ` Christian Borntraeger
2019-03-01 12:36 ` Cornelia Huck
2019-03-01 15:32 ` Pierre Morel
2019-02-28 13:10 ` Pierre Morel
2019-02-28 15:36 ` Tony Krowiak
2019-02-28 12:39 ` Halil Pasic
2019-02-28 14:12 ` Pierre Morel
2019-02-28 16:51 ` Halil Pasic
2019-03-01 12:10 ` Pierre Morel
2019-02-28 15:43 ` Tony Krowiak
2019-02-28 13:23 ` Pierre Morel
2019-02-28 13:44 ` Christian Borntraeger
2019-02-28 13:47 ` Pierre Morel
2019-02-28 14:07 ` Halil Pasic
2019-02-28 14:13 ` Pierre Morel
2019-02-28 15:45 ` Tony Krowiak
2019-02-28 15:35 ` Tony Krowiak
2019-03-01 8:42 ` Christian Borntraeger
2019-02-28 8:31 ` Christian Borntraeger
2019-02-22 15:29 ` [PATCH v4 2/7] s390: ap: new vfio_ap_queue structure Pierre Morel
2019-02-26 16:10 ` Tony Krowiak
2019-02-27 8:40 ` Pierre Morel
2019-02-27 20:35 ` Tony Krowiak
2019-02-22 15:29 ` [PATCH v4 3/7] s390: ap: associate a ap_vfio_queue and a matrix mdev Pierre Morel
2019-02-26 18:14 ` Tony Krowiak
2019-02-27 9:29 ` Pierre Morel
2019-02-27 20:14 ` Tony Krowiak
2019-02-27 9:32 ` Cornelia Huck
2019-02-27 10:21 ` Pierre Morel
2019-02-27 10:44 ` Pierre Morel
2019-02-27 20:53 ` Tony Krowiak
2019-03-04 2:09 ` Halil Pasic
2019-03-04 10:19 ` Pierre Morel
2019-03-05 22:17 ` Tony Krowiak
2019-03-12 21:39 ` Tony Krowiak
2019-03-13 10:19 ` Pierre Morel
2019-02-22 15:29 ` [PATCH v4 4/7] vfio: ap: register IOMMU VFIO notifier Pierre Morel
2019-02-27 9:42 ` Cornelia Huck
2019-02-27 10:22 ` Pierre Morel
2019-02-28 8:23 ` Christian Borntraeger
2019-02-28 8:48 ` Pierre Morel
2019-02-28 16:55 ` Halil Pasic
2019-03-01 7:51 ` Christian Borntraeger
2019-02-22 15:29 ` [PATCH v4 5/7] s390: ap: implement PAPQ AQIC interception in kernel Pierre Morel
2019-02-26 18:23 ` Tony Krowiak
2019-02-27 9:54 ` Pierre Morel
2019-02-27 18:17 ` Tony Krowiak
2019-02-27 18:18 ` Tony Krowiak
2019-02-28 20:20 ` Christian Borntraeger
2019-03-01 9:35 ` Pierre Morel
2019-03-04 1:57 ` Halil Pasic
2019-03-04 9:47 ` Pierre Morel
2019-02-22 15:29 ` [PATCH v4 6/7] s390: ap: Cleanup on removing the AP device Pierre Morel
2019-02-26 18:27 ` Tony Krowiak
2019-02-27 9:58 ` Pierre Morel
2019-03-04 13:02 ` Cornelia Huck
2019-03-08 22:43 ` Tony Krowiak
2019-03-11 8:31 ` Pierre Morel
2019-03-12 21:53 ` Tony Krowiak
2019-03-13 10:15 ` Pierre Morel [this message]
2019-02-22 15:30 ` [PATCH v4 7/7] s390: ap: kvm: Enable PQAP/AQIC facility for the guest Pierre Morel
2019-02-28 15:08 ` [PATCH v4 0/7] vfio: ap: AP Queue Interrupt Control Halil Pasic
2019-03-01 9:40 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85f772b4-0b62-701d-c3e5-e55e88c3fb4e@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).