* [PATCH -next] virt: sevguest: Fix return value check in alloc_shared_pages()
@ 2022-04-11 11:12 Yang Yingliang
2022-04-11 13:58 ` Brijesh Singh
2022-04-11 16:08 ` [tip: x86/sev] " tip-bot2 for Yang Yingliang
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-04-11 11:12 UTC (permalink / raw)
To: linux-kernel; +Cc: brijesh.singh, bp
If alloc_pages() fails, it returns NULL pointer, replaces
IS_ERR() check with NULL pointer check.
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/virt/coco/sevguest/sevguest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virt/coco/sevguest/sevguest.c b/drivers/virt/coco/sevguest/sevguest.c
index 15afb6ce8d19..aaa6134d1d40 100644
--- a/drivers/virt/coco/sevguest/sevguest.c
+++ b/drivers/virt/coco/sevguest/sevguest.c
@@ -581,7 +581,7 @@ static void *alloc_shared_pages(size_t sz)
int ret;
page = alloc_pages(GFP_KERNEL_ACCOUNT, get_order(sz));
- if (IS_ERR(page))
+ if (!page)
return NULL;
ret = set_memory_decrypted((unsigned long)page_address(page), npages);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] virt: sevguest: Fix return value check in alloc_shared_pages()
2022-04-11 11:12 [PATCH -next] virt: sevguest: Fix return value check in alloc_shared_pages() Yang Yingliang
@ 2022-04-11 13:58 ` Brijesh Singh
2022-04-11 16:08 ` [tip: x86/sev] " tip-bot2 for Yang Yingliang
1 sibling, 0 replies; 3+ messages in thread
From: Brijesh Singh @ 2022-04-11 13:58 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel; +Cc: brijesh.singh, bp
On 4/11/22 06:12, Yang Yingliang wrote:
> If alloc_pages() fails, it returns NULL pointer, replaces
> IS_ERR() check with NULL pointer check.
>
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: x86/sev] virt: sevguest: Fix return value check in alloc_shared_pages()
2022-04-11 11:12 [PATCH -next] virt: sevguest: Fix return value check in alloc_shared_pages() Yang Yingliang
2022-04-11 13:58 ` Brijesh Singh
@ 2022-04-11 16:08 ` tip-bot2 for Yang Yingliang
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Yang Yingliang @ 2022-04-11 16:08 UTC (permalink / raw)
To: linux-tip-commits
Cc: Hulk Robot, Yang Yingliang, Borislav Petkov, Brijesh Singh, x86,
linux-kernel
The following commit has been merged into the x86/sev branch of tip:
Commit-ID: e50abbf788c239d529f9ab81e325f8e8f8432c9d
Gitweb: https://git.kernel.org/tip/e50abbf788c239d529f9ab81e325f8e8f8432c9d
Author: Yang Yingliang <yangyingliang@huawei.com>
AuthorDate: Mon, 11 Apr 2022 19:12:13 +08:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 11 Apr 2022 17:58:52 +02:00
virt: sevguest: Fix return value check in alloc_shared_pages()
If alloc_pages() fails, it returns a NULL pointer. Replace the wrong
IS_ERR() check with the proper NULL pointer check.
Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
Link: https://lore.kernel.org/r/20220411111213.1477853-1-yangyingliang@huawei.com
---
drivers/virt/coco/sevguest/sevguest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virt/coco/sevguest/sevguest.c b/drivers/virt/coco/sevguest/sevguest.c
index 15afb6c..aaa6134 100644
--- a/drivers/virt/coco/sevguest/sevguest.c
+++ b/drivers/virt/coco/sevguest/sevguest.c
@@ -581,7 +581,7 @@ static void *alloc_shared_pages(size_t sz)
int ret;
page = alloc_pages(GFP_KERNEL_ACCOUNT, get_order(sz));
- if (IS_ERR(page))
+ if (!page)
return NULL;
ret = set_memory_decrypted((unsigned long)page_address(page), npages);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-11 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 11:12 [PATCH -next] virt: sevguest: Fix return value check in alloc_shared_pages() Yang Yingliang
2022-04-11 13:58 ` Brijesh Singh
2022-04-11 16:08 ` [tip: x86/sev] " tip-bot2 for Yang Yingliang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).