From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Odelu Kukatla <quic_okukatla@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: interconnect: Add QDU1000/QRU1000 devices
Date: Wed, 21 Dec 2022 08:58:53 +0100 [thread overview]
Message-ID: <86592f50-b1d9-b633-4ec8-904a7fd97806@linaro.org> (raw)
In-Reply-To: <20221216230914.21771-2-quic_molvera@quicinc.com>
On 17/12/2022 00:09, Melody Olvera wrote:
> Add separate schema for QDU1000 and QRU1000 interconnect devices
> to document the different NoCs on these platforms.
>
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
> .../interconnect/qcom,qdu1000-rpmh.yaml | 70 +++++++++++++
> .../interconnect/qcom,qdu1000-rpmh.h | 98 +++++++++++++++++++
> 2 files changed, 168 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qdu1000-rpmh.yaml
> create mode 100644 include/dt-bindings/interconnect/qcom,qdu1000-rpmh.h
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qdu1000-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qdu1000-rpmh.yaml
> new file mode 100644
> index 000000000000..dad93b8e4895
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,qdu1000-rpmh.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,qdu1000-rpmh.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm RPMh Network-On-Chip Interconnect on QDU1000
> +
> +maintainers:
> + - Georgi Djakov <djakov@kernel.org>
> + - Odelu Kukatla <quic_okukatla@quicinc.com>
> +
> +description: |
> + RPMh interconnect providers support system bandwidth requirements through
> + RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is
> + able to communicate with the BCM through the Resource State Coordinator (RSC)
> + associated with each execution environment. Provider nodes must point to at
> + least one RPMh device child node pertaining to their RSC and each provider
> + can map to multiple RPMh resources.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,qdu1000-clk-virt
> + - qcom,qdu1000-gem-noc
> + - qcom,qdu1000-mc-virt
> + - qcom,qdu1000-system-noc
> +
> + '#interconnect-cells': true
> +
> + reg:
> + maxItems: 1
> +
> +allOf:
> + - $ref: qcom,rpmh-common.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qdu1000-clk-virt
> + - qcom,qdu1000-mc-virt
> + then:
> + properties:
> + reg: false
> + else:
> + required:
> + - reg
> +
> +required:
> + - compatible
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interconnect/qcom,qdu1000-rpmh.h>
> +
> + system_noc: interconnect@1640000 {
> + compatible = "qcom,qdu1000-system-noc";
Messed indentation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-21 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 23:09 [PATCH v5 0/2] Add interconnect support for QDU1000/QRU1000 SoCs Melody Olvera
2022-12-16 23:09 ` [PATCH v5 1/2] dt-bindings: interconnect: Add QDU1000/QRU1000 devices Melody Olvera
2022-12-20 18:48 ` Rob Herring
2022-12-21 7:58 ` Krzysztof Kozlowski [this message]
2022-12-16 23:09 ` [PATCH v5 2/2] interconnect: qcom: Add QDU1000/QRU1000 interconnect driver Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86592f50-b1d9-b633-4ec8-904a7fd97806@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).