From: Marc Zyngier <maz@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Linus Walleij <linus.walleij@linaro.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
rayagonda.kokatanur@broadcom.com, li.jin@broadcom.com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
Date: Mon, 07 Oct 2019 09:14:38 +0100 [thread overview]
Message-ID: <86blutdlap.wl-maz@kernel.org> (raw)
In-Reply-To: <CAMuHMdV7syxxtnHEcgFBrf5DLo-M_71tZFWHHQ6kTO=2A1eVhg@mail.gmail.com>
On Mon, 07 Oct 2019 08:30:50 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Chris,
>
> CC MarcZ
>
> On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> > Use the dev_name(dev) for the irqc->name so that we get unique names
> > when we have multiple instances of this driver.
> >
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> A while ago, Marc Zyngier pointed out that the irq_chip .name field
> should contain the device's class name, not the instance's name.
> Hence the current code is correct?
Thanks Geert for looping me in. The main reasons why I oppose this
kind of "let's show as much information as we can in /proc/interrupts"
are:
- It clutters the output badly: the formatting of this file, which is
bad enough when you have a small number of CPUs, becomes unreadable
when you have a large number of them *and* stupidly long strings
that only make sense on a given platform.
- Like it or not, /proc is ABI. We don't change things randomly there
without a good reason, and debugging isn't one of them.
- Debug information belongs to debugfs, where we already have plenty
of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
this infrastructure if needed, rather than add platform specific
hacks.
</rant>
Thanks,
M.
>
> See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent"
> (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/)
> Note that the irqchip patches in that series have been applied; the gpio
> patches haven't been applied yet.
>
> > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> > @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
> > struct gpio_irq_chip *girq;
> >
> > irqc = &chip->irqchip;
> > - irqc->name = "bcm-iproc-gpio";
> > + irqc->name = dev_name(dev);
> > irqc->irq_ack = iproc_gpio_irq_ack;
> > irqc->irq_mask = iproc_gpio_irq_mask;
> > irqc->irq_unmask = iproc_gpio_irq_unmask;
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
--
Jazz is not dead, it just smells funny.
next prev parent reply other threads:[~2019-10-07 8:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 0:03 [PATCH v2 0/2] pinctrl: iproc: improve error handling Chris Packham
2019-10-03 0:03 ` [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq() Chris Packham
2019-10-03 18:36 ` Scott Branden
2019-10-05 16:35 ` Linus Walleij
2019-10-03 0:03 ` [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip Chris Packham
2019-10-03 18:36 ` Scott Branden
2019-10-05 16:37 ` Linus Walleij
2019-10-07 7:30 ` Geert Uytterhoeven
2019-10-07 8:14 ` Marc Zyngier [this message]
2019-10-07 17:10 ` Scott Branden
2019-10-13 21:02 ` Chris Packham
2019-10-11 7:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86blutdlap.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=geert@linux-m68k.org \
--cc=li.jin@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).