linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Chris Packham <chris.packham@alliedtelesis.co.nz>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
	Li Jin <li.jin@broadcom.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip
Date: Fri, 11 Oct 2019 09:26:54 +0200	[thread overview]
Message-ID: <CACRpkdb7W1iitkRh=B-cw1JGPey76SrAgasvHkh8a81o3n9qGQ@mail.gmail.com> (raw)
In-Reply-To: <86blutdlap.wl-maz@kernel.org>

On Mon, Oct 7, 2019 at 10:14 AM Marc Zyngier <maz@kernel.org> wrote:
> On Mon, 07 Oct 2019 08:30:50 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Chris,
> >
> > CC MarcZ
> >
> > On Thu, Oct 3, 2019 at 2:03 AM Chris Packham
> > <chris.packham@alliedtelesis.co.nz> wrote:
> > > Use the dev_name(dev) for the irqc->name so that we get unique names
> > > when we have multiple instances of this driver.
> > >
> > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> >
> > A while ago, Marc Zyngier pointed out that the irq_chip .name field
> > should contain the device's class name, not the instance's name.
> > Hence the current code is correct?
>
> Thanks Geert for looping me in. The main reasons why I oppose this
> kind of "let's show as much information as we can in /proc/interrupts"
> are:
>
> - It clutters the output badly: the formatting of this file, which is
>   bad enough when you have a small number of CPUs, becomes unreadable
>   when you have a large number of them *and* stupidly long strings
>   that only make sense on a given platform.
>
> - Like it or not, /proc is ABI. We don't change things randomly there
>   without a good reason, and debugging isn't one of them.
>
> - Debug information belongs to debugfs, where we already have plenty
>   of stuff (see CONFIG_GENERIC_IRQ_DEBUGFS). I'd rather we improve
>   this infrastructure if needed, rather than add platform specific
>   hacks.
>
> </rant>

I have reverted the patch.

Yours,
Linus Walleij

      parent reply	other threads:[~2019-10-11  7:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03  0:03 [PATCH v2 0/2] pinctrl: iproc: improve error handling Chris Packham
2019-10-03  0:03 ` [PATCH v2 1/2] pinctrl: iproc: allow for error from platform_get_irq() Chris Packham
2019-10-03 18:36   ` Scott Branden
2019-10-05 16:35   ` Linus Walleij
2019-10-03  0:03 ` [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip Chris Packham
2019-10-03 18:36   ` Scott Branden
2019-10-05 16:37   ` Linus Walleij
2019-10-07  7:30   ` Geert Uytterhoeven
2019-10-07  8:14     ` Marc Zyngier
2019-10-07 17:10       ` Scott Branden
2019-10-13 21:02         ` Chris Packham
2019-10-11  7:26       ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdb7W1iitkRh=B-cw1JGPey76SrAgasvHkh8a81o3n9qGQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=geert@linux-m68k.org \
    --cc=li.jin@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=rayagonda.kokatanur@broadcom.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).