From: Marc Zyngier <marc.zyngier@arm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@google.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: Re: linux-next: build warning after merge of the irqchip tree
Date: Sat, 15 Dec 2018 09:16:14 +0000 [thread overview]
Message-ID: <86sgyzb15t.wl-marc.zyngier@arm.com> (raw)
In-Reply-To: <20181214144406.0dbffbc8@canb.auug.org.au>
On Fri, 14 Dec 2018 03:44:06 +0000,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> [1 <text/plain; US-ASCII (quoted-printable)>]
> Hi all,
>
> After merging the irqchip tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/io.h:25,
> from include/linux/of_address.h:7,
> from drivers/irqchip/irq-imx-gpcv2.c:9:
> drivers/irqchip/irq-imx-gpcv2.c: In function 'imx_gpcv2_irqchip_init':
> arch/arm/include/asm/io.h:96:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> arch/arm/include/asm/io.h:305:29: note: in expansion of macro '__raw_writel'
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> drivers/irqchip/irq-imx-gpcv2.c:263:4: note: in expansion of macro 'writel_relaxed'
> writel_relaxed(~0, reg + GPC_IMR1_CORE3);
> ^~~~~~~~~~~~~~
> drivers/irqchip/irq-imx-gpcv2.c:264:3: note: here
> case 2: /* FALLTHROUGH */
> ^~~~
>
> Introduced by commit
>
> ed01edc0ab6f ("irqchip/irq-imx-gpcv2: Add support for i.MX8MQ")
>
> This is caused by my use of -Wimplicit-fallthrough for Kees Cook.
>
> Replacing the "/* FALLTHROUGH */" with "/* fall through */" but on the
> line above will suppress the warning.
I've now pushed out a patch that does exactly that. Thanks for
spotting this.
M.
--
Jazz is not dead, it just smell funny.
next prev parent reply other threads:[~2018-12-15 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 3:44 linux-next: build warning after merge of the irqchip tree Stephen Rothwell
2018-12-15 9:16 ` Marc Zyngier [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-13 9:44 Stephen Rothwell
2021-09-03 6:47 ` Stephen Rothwell
2021-09-03 9:00 ` Marc Zyngier
2021-06-15 11:01 Stephen Rothwell
2021-07-08 2:18 ` Stephen Rothwell
2021-07-08 8:10 ` Marc Zyngier
2021-07-08 12:50 ` Stephen Rothwell
2021-07-08 16:32 ` Marc Zyngier
2021-07-08 21:41 ` Stephen Rothwell
2021-06-07 23:21 Stephen Rothwell
2021-06-08 7:36 ` Marc Zyngier
2014-11-27 6:28 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sgyzb15t.wl-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=andrew.smirnov@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).