From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rxrpc: remove duplicate 'error' variable
Date: Tue, 06 Sep 2016 15:39:59 +0200 [thread overview]
Message-ID: <8706362.vunRxcsNaf@wuerfel> (raw)
In-Reply-To: <32472.1473168842@warthog.procyon.org.uk>
On Tuesday, September 6, 2016 2:34:02 PM CEST David Howells wrote:
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > The rxrpc_process_call function has debug code to print a failure code,
> > but instead of printing the code from the rxrpc_call structure, it
> > prints an uninitialized variable:
> >
> > net/rxrpc/call_event.c: In function 'rxrpc_process_call':
> > net/rxrpc/call_event.c:879:58: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> >
> > This removes the extraneous variable and prints the correct
> > code instead.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: f5c17aaeb2ae ("rxrpc: Calls should only have one terminal state")
>
> I've already posted a fix and it's waiting on DaveM.
>
> https://patchwork.ozlabs.org/patch/665550/
>
> http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/commit/?h=rxrpc-rewrite&id=00b5407e427ac2588a2496b92035a94602b3cd1b
Ok, good. At least I'm glad my patch is correct this time (being identical
to yours).
Arnd
prev parent reply other threads:[~2016-09-06 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:25 [PATCH] rxrpc: remove duplicate 'error' variable Arnd Bergmann
2016-09-06 13:34 ` David Howells
2016-09-06 13:39 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8706362.vunRxcsNaf@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).