linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx
@ 2023-08-01 11:51 Anvesh Jain P
  2023-08-01 15:32 ` Conor Dooley
  2023-08-16  5:53 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Anvesh Jain P @ 2023-08-01 11:51 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Satya Priya
  Cc: linux-arm-msm, devicetree, linux-kernel, Venkata Rao Kakani,
	Anvesh Jain P

Update rtc-pm8xxx bindings with disable-alarm-wakeup property.

Signed-off-by: Venkata Rao Kakani <quic_vkakani@quicinc.com>
Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
---
 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
index 9c51c1b19067..e4f1d2ff02b6 100644
--- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
@@ -42,6 +42,9 @@ properties:
 
   interrupt-controller: true
 
+  disable-alarm-wakeup:
+    description: optional, disable alarm wake up capability.
+
 patternProperties:
   "led@[0-9a-f]+$":
     type: object

base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx
  2023-08-01 11:51 [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx Anvesh Jain P
@ 2023-08-01 15:32 ` Conor Dooley
  2023-08-16  5:53 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-08-01 15:32 UTC (permalink / raw)
  To: Anvesh Jain P
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Satya Priya,
	linux-arm-msm, devicetree, linux-kernel, Venkata Rao Kakani

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Tue, Aug 01, 2023 at 05:21:43PM +0530, Anvesh Jain P wrote:
> Update rtc-pm8xxx bindings with disable-alarm-wakeup property.
> 
> Signed-off-by: Venkata Rao Kakani <quic_vkakani@quicinc.com>
> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>

The corresponding driver patch, afaict got NAKed.
Why were they not sent together?

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> index 9c51c1b19067..e4f1d2ff02b6 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> @@ -42,6 +42,9 @@ properties:
>  
>    interrupt-controller: true
>  
> +  disable-alarm-wakeup:
> +    description: optional, disable alarm wake up capability.
> +
>  patternProperties:
>    "led@[0-9a-f]+$":
>      type: object
> 
> base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx
  2023-08-01 11:51 [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx Anvesh Jain P
  2023-08-01 15:32 ` Conor Dooley
@ 2023-08-16  5:53 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-16  5:53 UTC (permalink / raw)
  To: Anvesh Jain P, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Satya Priya
  Cc: linux-arm-msm, devicetree, linux-kernel, Venkata Rao Kakani

On 01/08/2023 13:51, Anvesh Jain P wrote:
> Update rtc-pm8xxx bindings with disable-alarm-wakeup property.
> 
> Signed-off-by: Venkata Rao Kakani <quic_vkakani@quicinc.com>
> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
> ---
>  Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> index 9c51c1b19067..e4f1d2ff02b6 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> @@ -42,6 +42,9 @@ properties:
>  
>    interrupt-controller: true
>  
> +  disable-alarm-wakeup:
> +    description: optional, disable alarm wake up capability.

This was no tested. Missing type, vendor prefix. Additionally the
description says absolutely nothing, just repeats the schema.

Sorry, does not look like hardware property with such description.

Anyway sending it without DTS or driver is also no-go, so NAK, sorry.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-16  5:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-01 11:51 [PATCH] bindings: mfd: qcom-pm8xxx: add a property for rtc-pm8xxx Anvesh Jain P
2023-08-01 15:32 ` Conor Dooley
2023-08-16  5:53 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).