From: Takashi Iwai <tiwai@suse.de>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Takashi Iwai <tiwai@suse.de>, Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <jroedel@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Eric Auger <eric.auger@redhat.com>,
regressions@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19
Date: Thu, 08 Sep 2022 08:23:18 +0200 [thread overview]
Message-ID: <871qsme65l.wl-tiwai@suse.de> (raw)
In-Reply-To: <YxihMchpLRPAqNWx@nvidia.com>
On Wed, 07 Sep 2022 15:48:33 +0200,
Jason Gunthorpe wrote:
>
> On Wed, Sep 07, 2022 at 03:28:31PM +0200, Takashi Iwai wrote:
> > > /**
> > > * iommu_device_use_default_domain() - Device driver wants to handle device
> > > * DMA through the kernel DMA API.
> > > @@ -3094,8 +3112,7 @@ int iommu_device_use_default_domain(struct device *dev)
> > >
> > > mutex_lock(&group->mutex);
> > > if (group->owner_cnt) {
> > > - if (group->domain != group->default_domain ||
> > > - group->owner) {
> > > + if (group->owner || iommu_is_default_domain(group)) {
> >
> > Isn't this rather
> > if (group->owner || !iommu_is_default_domain(group)) {
> > ?
> >
> > I'll rebuild the kernel with this change and ask reporters again.
>
> Oh yes, good eyes, that probably crashes on boot too
Indeed the corrected patch seems working; it boots and the HD-audio
device appears again.
Can we go forward with this?
thanks,
Takashi
next prev parent reply other threads:[~2022-09-08 6:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 14:12 [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19 Takashi Iwai
2022-08-23 1:00 ` Jason Gunthorpe
2022-08-23 6:06 ` Takashi Iwai
2022-08-23 11:46 ` Takashi Iwai
2022-08-23 20:28 ` Jason Gunthorpe
2022-08-23 21:01 ` Robin Murphy
2022-08-24 0:02 ` Jason Gunthorpe
2022-09-06 15:41 ` Jason Gunthorpe
2022-09-06 15:52 ` Takashi Iwai
2022-09-06 15:53 ` Jason Gunthorpe
2022-09-06 16:04 ` Takashi Iwai
2022-09-06 16:08 ` Jason Gunthorpe
2022-09-06 16:16 ` Takashi Iwai
2022-09-07 10:08 ` Takashi Iwai
2022-09-07 13:28 ` Takashi Iwai
2022-09-07 13:48 ` Jason Gunthorpe
2022-09-08 6:23 ` Takashi Iwai [this message]
2022-08-24 7:13 ` Thorsten Leemhuis
2022-09-19 15:23 ` [REGRESSION 5.19.x] AMD HD-audio devices missing on 5.19 #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qsme65l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).