From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: CONFIG_COMMON_CLK vs CONFIG_HAVE_CLK
Date: 12 Dec 2019 11:09:22 +0900 [thread overview]
Message-ID: <871rtae1m5.wl-kuninori.morimoto.gx@renesas.com> (raw)
Hi
I noticed that there are some CONFIG_HAVE_CLK vs CONFIG_COMMON_CLK mismatch.
Because of it, I got compile error at clk_set_min_rate() on SH.
SH will have HAVE_CLK, but doesn't have COMMON_CLK.
> ARCH=sh make allyesconfig
> make
...
drivers/devfreq/tegra30-devfreq.o: In function `tegra_devfreq_target':
tegra30-devfreq.c:(.text+0x368): undefined reference to `clk_set_min_rate'
clk_set_min_rate() is under HAVE_CLK at clk.h
--- clk.h ---
=> #ifdef CONFIG_HAVE_CLK
...
int clk_set_min_rate(struct clk *clk, unsigned long rate);
...
#else /* !CONFIG_HAVE_CLK */
static inline int clk_set_min_rate(struct clk *clk, unsigned long rate)
...
-------------
It is implemented at clk.c.
But it will be compiled via COMMON_CLK
--- Makefile ---
...
=> obj-$(CONFIG_COMMON_CLK) += clk.o
...
----------------
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next reply other threads:[~2019-12-12 2:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 2:09 Kuninori Morimoto [this message]
2019-12-12 10:57 ` CONFIG_COMMON_CLK vs CONFIG_HAVE_CLK Enrico Weigelt, metux IT consult
2019-12-12 21:51 ` Stephen Boyd
2019-12-13 4:41 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rtae1m5.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).