* [PATCH] ALSA: wavefront: remove redundant assignment to pointer end
@ 2022-06-29 10:27 Colin Ian King
2022-06-29 10:27 ` Colin Ian King
2022-07-04 12:30 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-06-29 10:27 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
Pointer end is being re-assigned the same value as it was initialized
with in the previous statement. The re-assignment is redundant and
can be removed.
Cleans up clang scan-build warning:
sound/isa/wavefront/wavefront_synth.c:582:17: warning: Value stored
to 'end' during its initialization is never read
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
sound/isa/wavefront/wavefront_synth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
index 2aaaa6807174..13ce96148fa3 100644
--- a/sound/isa/wavefront/wavefront_synth.c
+++ b/sound/isa/wavefront/wavefront_synth.c
@@ -581,8 +581,6 @@ demunge_buf (unsigned char *src, unsigned char *dst, unsigned int src_bytes)
int i;
unsigned char *end = src + src_bytes;
- end = src + src_bytes;
-
/* NOTE: src and dst *CAN* point to the same address */
for (i = 0; src != end; i++) {
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ALSA: wavefront: remove redundant assignment to pointer end
2022-06-29 10:27 [PATCH] ALSA: wavefront: remove redundant assignment to pointer end Colin Ian King
@ 2022-06-29 10:27 ` Colin Ian King
2022-07-04 12:30 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2022-06-29 10:27 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel; +Cc: kernel-janitors, linux-kernel
Pointer end is being re-assigned the same value as it was initialized
with in the previous statement. The re-assignment is redundant and
can be removed.
Cleans up clang scan-build warning:
sound/isa/wavefront/wavefront_synth.c:582:17: warning: Value stored
to 'end' during its initialization is never read
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
sound/isa/wavefront/wavefront_synth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
index 2aaaa6807174..13ce96148fa3 100644
--- a/sound/isa/wavefront/wavefront_synth.c
+++ b/sound/isa/wavefront/wavefront_synth.c
@@ -581,8 +581,6 @@ demunge_buf (unsigned char *src, unsigned char *dst, unsigned int src_bytes)
int i;
unsigned char *end = src + src_bytes;
- end = src + src_bytes;
-
/* NOTE: src and dst *CAN* point to the same address */
for (i = 0; src != end; i++) {
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: wavefront: remove redundant assignment to pointer end
2022-06-29 10:27 [PATCH] ALSA: wavefront: remove redundant assignment to pointer end Colin Ian King
2022-06-29 10:27 ` Colin Ian King
@ 2022-07-04 12:30 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2022-07-04 12:30 UTC (permalink / raw)
To: Colin Ian King
Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, kernel-janitors, linux-kernel
On Wed, 29 Jun 2022 12:27:43 +0200,
Colin Ian King wrote:
>
> Pointer end is being re-assigned the same value as it was initialized
> with in the previous statement. The re-assignment is redundant and
> can be removed.
>
> Cleans up clang scan-build warning:
> sound/isa/wavefront/wavefront_synth.c:582:17: warning: Value stored
> to 'end' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-04 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 10:27 [PATCH] ALSA: wavefront: remove redundant assignment to pointer end Colin Ian King
2022-06-29 10:27 ` Colin Ian King
2022-07-04 12:30 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).