From: Michael Ellerman <mpe@ellerman.id.au>
To: Shuah Khan <shuah@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
yamada.masahiro@socionext.com, michal.lkml@markovi.net,
bamv2005@gmail.com, brgl@bgdev.pl, pbonzini@redhat.com,
akpm@linux-foundation.org, rppt@linux.vnet.ibm.com,
aarcange@redhat.com
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v6] selftests: add headers_install to lib.mk
Date: Wed, 03 Oct 2018 00:12:51 +1000 [thread overview]
Message-ID: <8736tol9ng.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <4473d2b6-a760-1a48-68e7-9f90023b57b5@kernel.org>
Shuah Khan <shuah@kernel.org> writes:
> On 09/27/2018 10:52 PM, Michael Ellerman wrote:
>> [ + linuxppc-dev ]
>>
>> Anders Roxell <anders.roxell@linaro.org> writes:
>>> If the kernel headers aren't installed we can't build all the tests.
>>> Add a new make target rule 'khdr' in the file lib.mk to generate the
>>> kernel headers and that gets include for every test-dir Makefile that
>>> includes lib.mk If the testdir in turn have its own sub-dirs the
>>> top_srcdir needs to be set to the linux-rootdir to be able to generate
>>> the kernel headers.
>>>
>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>> Reviewed-by: Fathi Boudra <fathi.boudra@linaro.org>
>>> ---
>>>
>>> I sent this (v5) a month ago and wondered if it got lost. Resending
>>> unchanged.
>>>
>>> Cheers,
>>> Anders
>>>
>>> Makefile | 14 +-------------
>>> scripts/subarch.include | 13 +++++++++++++
>>> tools/testing/selftests/android/Makefile | 2 +-
>>> tools/testing/selftests/android/ion/Makefile | 2 ++
>>> tools/testing/selftests/futex/functional/Makefile | 1 +
>>> tools/testing/selftests/gpio/Makefile | 7 ++-----
>>> tools/testing/selftests/kvm/Makefile | 7 ++-----
>>> tools/testing/selftests/lib.mk | 12 ++++++++++++
>>> tools/testing/selftests/net/Makefile | 1 +
>>> .../selftests/networking/timestamping/Makefile | 1 +
>>> tools/testing/selftests/vm/Makefile | 4 ----
>>> 11 files changed, 36 insertions(+), 28 deletions(-)
>>> create mode 100644 scripts/subarch.include
>>
>> This broke all the powerpc selftests :(
>
> Sorry for thr breakage.
>
>> Why did it go in at rc5?
>
> This patch has been in linux-next for a sometime before I decided to send this.
> My original intent was to send this for rc2, and my schedule was messed up with
> traveling. Since I didn't hear any issues from linux-next soaking, I made a call
> on sending this in for rc5.
OK. And I didn't notice the breakage in linux-next because _I_ was
travelling :)
> On second thought I should have waited until 4.20. Sorry about that.
Yeah that would have been better, no worries.
cheers
prev parent reply other threads:[~2018-10-02 14:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 10:23 [PATCH] selftests: add headers_install to lib.mk Anders Roxell
2018-04-13 9:03 ` [PATCH v2] " Anders Roxell
2018-05-14 11:58 ` [PATCH v3] " Anders Roxell
2018-05-14 17:16 ` Paolo Bonzini
2018-05-14 18:44 ` Mike Rapoport
2018-05-14 19:20 ` Daniel Borkmann
2018-06-07 11:07 ` Anders Roxell
2018-06-07 11:09 ` [PATCH v4] " Anders Roxell
2018-07-23 20:49 ` Anders Roxell
2018-07-24 17:10 ` Shuah Khan
2018-07-25 16:08 ` Anders Roxell
2018-08-06 17:03 ` Shuah Khan
2018-08-07 2:32 ` Masahiro Yamada
2018-08-08 10:44 ` Anders Roxell
2019-01-04 13:15 ` Geert Uytterhoeven
2018-08-09 8:04 ` [PATCH v5] " Anders Roxell
2018-09-04 10:47 ` [PATCH v6] " Anders Roxell
2018-09-05 14:13 ` Shuah Khan
2018-09-28 4:52 ` Michael Ellerman
2018-09-28 13:52 ` Shuah Khan
2018-10-02 14:12 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736tol9ng.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=bamv2005@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.lkml@markovi.net \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shuah@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).