From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Bhumika Goyal <bhumirks@gmail.com>,
julia.lawall@lip6.fr, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: dove: constify reset_control_ops structures
Date: Fri, 13 Jan 2017 17:55:26 +0100 [thread overview]
Message-ID: <8737gm99xd.fsf@free-electrons.com> (raw)
In-Reply-To: <20170113165020.GU14217@n2100.armlinux.org.uk> (Russell King's message of "Fri, 13 Jan 2017 16:50:21 +0000")
Hi Russell King,
On ven., janv. 13 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:
> On Fri, Jan 13, 2017 at 05:36:42PM +0100, Gregory CLEMENT wrote:
>> Hi Sebastian,
>>
>> On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
>>
>> > Declare reset_control_ops as const as they are only stored in the ops
>> > field of a reset_controller_dev structure. This field is of type const
>> > struct reset_control_ops *, so reset_control_ops structures having this
>> > property can be declared as const.
>> > Done using Coccinelle:
>> >
>> > @r1 disable optional_qualifier@
>> > identifier i;
>> > position p;
>> > @@
>> > static struct reset_control_ops i@p={...};
>> >
>> > @ok1@
>> > identifier r1.i;
>> > position p;
>> > struct reset_controller_dev x;
>> > @@
>> > x.ops=&i@p;
>> >
>> > @bad@
>> > position p!={r1.p,ok1.p};
>> > identifier r1.i;
>> > @@
>> > i@p
>> >
>> > @depends on !bad disable optional_qualifier@
>> > identifier r1.i;
>> > @@
>> > +const
>> > struct reset_control_ops i;
>> >
>> > File size before: drivers/soc/dove/pmu.o
>> > text data bss dec hex filename
>> > 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
>> >
>> > File size after: drivers/soc/dove/pmu.o
>> > text data bss dec hex filename
>> > 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
>> >
>>
>> If you agree with this patch I will apply it on mvebu/soc.
>
> You really ought to be asking me...
Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he
would have redirect me to you :)
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied on mvebu/soc
Thanks,
Gregory
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-01-13 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 16:34 [PATCH] soc: dove: constify reset_control_ops structures Bhumika Goyal
2017-01-13 16:36 ` Gregory CLEMENT
2017-01-13 16:50 ` Russell King - ARM Linux
2017-01-13 16:55 ` Gregory CLEMENT [this message]
2017-03-24 13:00 ` Russell King - ARM Linux
2017-03-24 14:40 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737gm99xd.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).