From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Bhumika Goyal <bhumirks@gmail.com>,
julia.lawall@lip6.fr, rmk+kernel@arm.linux.org.uk,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: dove: constify reset_control_ops structures
Date: Fri, 13 Jan 2017 17:36:42 +0100 [thread overview]
Message-ID: <87eg069asl.fsf@free-electrons.com> (raw)
In-Reply-To: <1483979690-7619-1-git-send-email-bhumirks@gmail.com> (Bhumika Goyal's message of "Mon, 9 Jan 2017 22:04:50 +0530")
Hi Sebastian,
On lun., janv. 09 2017, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Declare reset_control_ops as const as they are only stored in the ops
> field of a reset_controller_dev structure. This field is of type const
> struct reset_control_ops *, so reset_control_ops structures having this
> property can be declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct reset_control_ops i@p={...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct reset_controller_dev x;
> @@
> x.ops=&i@p;
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct reset_control_ops i;
>
> File size before: drivers/soc/dove/pmu.o
> text data bss dec hex filename
> 2447 112 16 2575 a0f drivers/soc/dove/pmu.o
>
> File size after: drivers/soc/dove/pmu.o
> text data bss dec hex filename
> 2479 80 16 2575 a0f drivers/soc/dove/pmu.o
>
If you agree with this patch I will apply it on mvebu/soc.
Thanks,
Gregory
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/soc/dove/pmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
> index 039374e..95d77ec 100644
> --- a/drivers/soc/dove/pmu.c
> +++ b/drivers/soc/dove/pmu.c
> @@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)
> return 0;
> }
>
> -static struct reset_control_ops pmu_reset_ops = {
> +static const struct reset_control_ops pmu_reset_ops = {
> .reset = pmu_reset_reset,
> .assert = pmu_reset_assert,
> .deassert = pmu_reset_deassert,
> --
> 1.9.1
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-01-13 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 16:34 [PATCH] soc: dove: constify reset_control_ops structures Bhumika Goyal
2017-01-13 16:36 ` Gregory CLEMENT [this message]
2017-01-13 16:50 ` Russell King - ARM Linux
2017-01-13 16:55 ` Gregory CLEMENT
2017-03-24 13:00 ` Russell King - ARM Linux
2017-03-24 14:40 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg069asl.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).