* [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info()
@ 2024-01-28 11:34 Christophe JAILLET
2024-01-29 5:43 ` Vaibhav Jain
2024-05-08 13:45 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2024-01-28 11:34 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy,
Aneesh Kumar K.V, Naveen N. Rao, Vaibhav Jain, Kautuk Consul,
Amit Machhiwal, Jordan Niethe
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
Gautam Menghani, linuxppc-dev, kvm
The return value of kvmppc_gse_put_buff_info() is not assigned to 'rc' and
'rc' is uninitialized at this point.
So the error handling can not work.
Assign the expected value to 'rc' to fix the issue.
Fixes: 19d31c5f1157 ("KVM: PPC: Add support for nestedv2 guests")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
arch/powerpc/kvm/book3s_hv_nestedv2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_hv_nestedv2.c b/arch/powerpc/kvm/book3s_hv_nestedv2.c
index 5378eb40b162..be5f87e69637 100644
--- a/arch/powerpc/kvm/book3s_hv_nestedv2.c
+++ b/arch/powerpc/kvm/book3s_hv_nestedv2.c
@@ -71,8 +71,8 @@ gs_msg_ops_kvmhv_nestedv2_config_fill_info(struct kvmppc_gs_buff *gsb,
}
if (kvmppc_gsm_includes(gsm, KVMPPC_GSID_RUN_OUTPUT)) {
- kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
- cfg->vcpu_run_output_cfg);
+ rc = kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
+ cfg->vcpu_run_output_cfg);
if (rc < 0)
return rc;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info()
2024-01-28 11:34 [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info() Christophe JAILLET
@ 2024-01-29 5:43 ` Vaibhav Jain
2024-05-08 13:45 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Vaibhav Jain @ 2024-01-29 5:43 UTC (permalink / raw)
To: Christophe JAILLET, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Aneesh Kumar K.V, Naveen N. Rao, Kautuk Consul,
Amit Machhiwal, Jordan Niethe
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
Gautam Menghani, linuxppc-dev, kvm
Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
<snip>
> if (kvmppc_gsm_includes(gsm, KVMPPC_GSID_RUN_OUTPUT)) {
> - kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
> - cfg->vcpu_run_output_cfg);
> + rc = kvmppc_gse_put_buff_info(gsb, KVMPPC_GSID_RUN_OUTPUT,
> + cfg->vcpu_run_output_cfg);
> if (rc < 0)
> return rc;
> }
> --
Thanks for catching this and the change looks good to me.
Reviewed-by: Vaibhav Jain <vaibhav@linux.ibm.com>
--
Cheers
~ Vaibhav
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info()
2024-01-28 11:34 [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info() Christophe JAILLET
2024-01-29 5:43 ` Vaibhav Jain
@ 2024-05-08 13:45 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2024-05-08 13:45 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy,
Aneesh Kumar K.V, Naveen N. Rao, Vaibhav Jain, Kautuk Consul,
Amit Machhiwal, Jordan Niethe, Christophe JAILLET
Cc: linux-kernel, kernel-janitors, Gautam Menghani, linuxppc-dev, kvm
On Sun, 28 Jan 2024 12:34:25 +0100, Christophe JAILLET wrote:
> The return value of kvmppc_gse_put_buff_info() is not assigned to 'rc' and
> 'rc' is uninitialized at this point.
> So the error handling can not work.
>
> Assign the expected value to 'rc' to fix the issue.
>
>
> [...]
Applied to powerpc/topic/ppc-kvm.
[1/1] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info()
https://git.kernel.org/powerpc/c/b52e8cd3f835869370f8540f1bc804a47a47f02b
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-08 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-28 11:34 [PATCH] KVM: PPC: Book3S HV nestedv2: Fix an error handling path in gs_msg_ops_kvmhv_nestedv2_config_fill_info() Christophe JAILLET
2024-01-29 5:43 ` Vaibhav Jain
2024-05-08 13:45 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).