* [PATCH] libertas: debugfs: Added missing spaces
[not found] <tencent_0EA6836B1E10A9623158112DD43D48C95605@qq.com>
@ 2023-07-19 9:31 ` hanyu001
2023-07-24 14:26 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: hanyu001 @ 2023-07-19 9:31 UTC (permalink / raw)
To: kvalo; +Cc: libertas-dev, linux-wireless, linux-kernel
Fixes the following checkpatch errors:
./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: space
required before the open parenthesis '('
./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: space
required before the open parenthesis '('
./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: space
required before the open parenthesis '('
Signed-off-by: Yu Han <hanyu001@208suo.com>
---
drivers/net/wireless/marvell/libertas/debugfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/marvell/libertas/debugfs.c
b/drivers/net/wireless/marvell/libertas/debugfs.c
index c604613..8939bf4 100644
--- a/drivers/net/wireless/marvell/libertas/debugfs.c
+++ b/drivers/net/wireless/marvell/libertas/debugfs.c
@@ -709,7 +709,7 @@ void lbs_debugfs_init_one(struct lbs_private *priv,
struct net_device *dev)
priv->debugfs_dir = debugfs_create_dir(dev->name, lbs_dir);
- for (i=0; i<ARRAY_SIZE(debugfs_files); i++) {
+ for (i = 0; i < ARRAY_SIZE(debugfs_files); i++) {
files = &debugfs_files[i];
priv->debugfs_files[i] = debugfs_create_file(files->name,
files->perm,
@@ -720,7 +720,7 @@ void lbs_debugfs_init_one(struct lbs_private *priv,
struct net_device *dev)
priv->events_dir = debugfs_create_dir("subscribed_events",
priv->debugfs_dir);
- for (i=0; i<ARRAY_SIZE(debugfs_events_files); i++) {
+ for (i = 0; i < ARRAY_SIZE(debugfs_events_files); i++) {
files = &debugfs_events_files[i];
priv->debugfs_events_files[i] =
debugfs_create_file(files->name,
files->perm,
@@ -731,7 +731,7 @@ void lbs_debugfs_init_one(struct lbs_private *priv,
struct net_device *dev)
priv->regs_dir = debugfs_create_dir("registers",
priv->debugfs_dir);
- for (i=0; i<ARRAY_SIZE(debugfs_regs_files); i++) {
+ for (i = 0; i < ARRAY_SIZE(debugfs_regs_files); i++) {
files = &debugfs_regs_files[i];
priv->debugfs_regs_files[i] = debugfs_create_file(files->name,
files->perm,
@@ -751,19 +751,19 @@ void lbs_debugfs_remove_one(struct lbs_private
*priv)
{
int i;
- for(i=0; i<ARRAY_SIZE(debugfs_regs_files); i++)
+ for (i = 0; i < ARRAY_SIZE(debugfs_regs_files); i++)
debugfs_remove(priv->debugfs_regs_files[i]);
debugfs_remove(priv->regs_dir);
- for(i=0; i<ARRAY_SIZE(debugfs_events_files); i++)
+ for (i = 0; i < ARRAY_SIZE(debugfs_events_files); i++)
debugfs_remove(priv->debugfs_events_files[i]);
debugfs_remove(priv->events_dir);
#ifdef PROC_DEBUG
debugfs_remove(priv->debugfs_debug);
#endif
- for(i=0; i<ARRAY_SIZE(debugfs_files); i++)
+ for (i = 0; i < ARRAY_SIZE(debugfs_files); i++)
debugfs_remove(priv->debugfs_files[i]);
debugfs_remove(priv->debugfs_dir);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libertas: debugfs: Added missing spaces
2023-07-19 9:31 ` [PATCH] libertas: debugfs: Added missing spaces hanyu001
@ 2023-07-24 14:26 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-07-24 14:26 UTC (permalink / raw)
To: hanyu001; +Cc: libertas-dev, linux-wireless, linux-kernel
hanyu001@208suo.com writes:
> Fixes the following checkpatch errors:
>
> ./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: space
> required before the open parenthesis '('
> ./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: space
> required before the open parenthesis '('
> ./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: space
> required before the open parenthesis '('
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
Please don't submit checkpatch fixes to linux-wireless, they are too
much work with very little gain. And libertas is an orphaned driver, we
want to make the absolute minimal changes to it.
I'm now going to silently reject all checkpatch patches in patchwork.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-24 14:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_0EA6836B1E10A9623158112DD43D48C95605@qq.com>
2023-07-19 9:31 ` [PATCH] libertas: debugfs: Added missing spaces hanyu001
2023-07-24 14:26 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).