From: Jani Nikula <jani.nikula@linux.intel.com>
To: Shayenne Moura <shayenneluzmoura@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency
Date: Wed, 19 Dec 2018 20:23:50 +0200 [thread overview]
Message-ID: <874lb9pe89.fsf@intel.com> (raw)
In-Reply-To: <20181219164013.dr7vgfbs2w3jtix7@smtp.gmail.com>
On Wed, 19 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote:
> On 12/19, Jani Nikula wrote:
>> On Tue, 18 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote:
>> > This patch serie removes drm_mode_object dependency from
>> > drm_display_mode struct. This is part of KMS cleanup.
>>
>> For future reference:
>>
>> Please use git-send-email or fix the mail threading otherwise. Patches
>> 1-7 should be in reply to the cover letter.
>>
> Sorry about that,
>> Please justify the changes in the commit messages. Your current commit
>> messages focus on *what* is being done, which is fairly obvious from the
>> changes themselves. Please try to describe *why* this is being
>> done. That's more important for posterity. (In this case, it's basically
>> explained in the FIXME comment being removed in patch 7, as well as
>> Documentation/gpu/todo.rst.)
>>
>> BR,
>> Jani.
>>
> Okay, thank you! But I should write on every patch why I am doing or
> just on the cover letter?
So this series is trivial enough that I can look the other way... ;)
But in general each patch should have a justification, even if just one
sentence in the commit message. The why. The commit messages get
recorded in git history, but the cover letter gets lost.
BR,
Jani.
>
> Bests,
> Shayenne
>>
>> >
>> > Shayenne Moura (7):
>> > drm: msm: Delete base.id prints
>> > drm: Remove use of drm_mode_object
>> > drm: omapdrm: Delete base.id prints
>> > drm: i915: Delete base.id prints
>> > drm: sti: Delete base.id prints
>> > drm: meson: Delete base.id prints
>> > drm: Complete remove drm_mode_object dependency
>> >
>> > drivers/gpu/drm/drm_crtc_helper.c | 5 ++---
>> > drivers/gpu/drm/drm_modes.c | 9 ---------
>> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
>> > drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++-----
>> > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 4 ++--
>> > drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 4 ++--
>> > drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 4 ++--
>> > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 4 ++--
>> > drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 4 ++--
>> > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++--
>> > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 4 ++--
>> > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++--
>> > drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++--
>> > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++--
>> > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++--
>> > drivers/gpu/drm/sti/sti_crtc.c | 4 ++--
>> > include/drm/drm_modes.h | 10 ++++------
>> > 17 files changed, 36 insertions(+), 49 deletions(-)
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2018-12-19 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 13:37 [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency Shayenne Moura
2018-12-19 13:07 ` Jani Nikula
2018-12-19 16:40 ` Shayenne Moura
2018-12-19 18:23 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lb9pe89.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=shayenneluzmoura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).