From: Michael Ellerman <mpe@ellerman.id.au>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
benh@kernel.crashing.org, paulus@samba.org,
sukadev@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
ast@kernel.org, eranian@google.com
Subject: Re: [PATCH v3 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src
Date: Thu, 20 Apr 2017 08:16:17 +1000 [thread overview]
Message-ID: <874lxk59hq.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <bfcf37a8-c195-655e-2e54-95744800d968@linux.vnet.ibm.com>
Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
> On Wednesday 19 April 2017 10:20 AM, Michael Ellerman wrote:
>> It also occurred to me that we don't actually have to redefine the whole
>> union, it's only the bitfields that matter, so we could reduce the diff
>> to:
>>
>> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
>> index c66a485a24ac..97152c79df6b 100644
>> --- a/include/uapi/linux/perf_event.h
>> +++ b/include/uapi/linux/perf_event.h
>> @@ -894,12 +894,23 @@ enum perf_callchain_context {
>> union perf_mem_data_src {
>> __u64 val;
>> struct {
>> +#if defined(__LITTLE_ENDIAN_BITFIELD)
>> __u64 mem_op:5, /* type of opcode */
>> mem_lvl:14, /* memory hierarchy level */
>> mem_snoop:5, /* snoop mode */
>> mem_lock:2, /* lock instr */
>> mem_dtlb:7, /* tlb access */
>> mem_rsvd:31;
>> +#elif defined(__BIG_ENDIAN_BITFIELD)
>> + __u64 mem_rsvd:31,
>> + mem_dtlb:7, /* tlb access */
>> + mem_lock:2, /* lock instr */
>> + mem_snoop:5, /* snoop mode */
>> + mem_lvl:14, /* memory hierarchy level */
>> + mem_op:5; /* type of opcode */
>> +#else
>> +#error "Unknown endianness"
>> +#endif
>> };
>> };
>>
>>
>> That looks better to me, thoughts?
>
> Yep. Looks fine to me and also tested the same.
I merged the original version, as that's what Peterz acked and I didn't
want to block the series any longer.
I'll send an incremental patch to do the cleanup.
cheers
next prev parent reply other threads:[~2017-04-19 22:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 1:51 [PATCH v3 0/6] powerpc/perf: Export memory hierarchy level Madhavan Srinivasan
2017-04-11 1:51 ` [PATCH v3 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src Madhavan Srinivasan
2017-04-13 12:38 ` Peter Zijlstra
2017-04-13 13:23 ` Michael Ellerman
2017-04-17 3:46 ` Madhavan Srinivasan
2017-04-17 3:46 ` Madhavan Srinivasan
2017-04-19 4:50 ` Michael Ellerman
2017-04-19 14:32 ` Madhavan Srinivasan
2017-04-19 22:16 ` Michael Ellerman [this message]
2017-04-19 22:04 ` [v3, " Michael Ellerman
2017-04-11 1:51 ` [PATCH v3 2/6] powerpc/perf: Export memory hierarchy info to user space Madhavan Srinivasan
2017-04-11 1:51 ` [PATCH v3 3/6] powerpc/perf: Support to export MMCRA[TEC*] field to userspace Madhavan Srinivasan
2017-04-11 1:51 ` [PATCH v3 4/6] powerpc/perf: Support to export SIERs bit in Power8 Madhavan Srinivasan
2017-04-11 1:51 ` [PATCH v3 5/6] powerpc/perf: Support to export SIERs bit in Power9 Madhavan Srinivasan
2017-04-11 1:51 ` [PATCH v3 6/6] powerpc/perf: Add Power8 mem_access event to sysfs Madhavan Srinivasan
-- strict thread matches above, loose matches on Subject: below --
2017-03-23 3:26 [PATCH v3 0/6] powerpc/perf: Export memory hierarchy level Madhavan Srinivasan
2017-03-23 3:26 ` [PATCH v3 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lxk59hq.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=ast@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).