* [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration
@ 2020-01-23 2:08 linmiaohe
2020-01-23 8:18 ` Vitaly Kuznetsov
2020-01-23 22:21 ` Krish Sadhukhan
0 siblings, 2 replies; 3+ messages in thread
From: linmiaohe @ 2020-01-23 2:08 UTC (permalink / raw)
To: pbonzini, rkrcmar, sean.j.christopherson, vkuznets, wanpengli,
jmattson, joro, tglx, mingo, bp, hpa
Cc: linmiaohe, kvm, linux-kernel, x86
From: Miaohe Lin <linmiaohe@huawei.com>
The function nested_vmx_run() declaration is below its implementation. So
this is meaningless and should be removed.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
arch/x86/kvm/vmx/nested.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
index 95b3f4306ac2..7608924ee8c1 100644
--- a/arch/x86/kvm/vmx/nested.c
+++ b/arch/x86/kvm/vmx/nested.c
@@ -4723,8 +4723,6 @@ static int handle_vmclear(struct kvm_vcpu *vcpu)
return nested_vmx_succeed(vcpu);
}
-static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch);
-
/* Emulate the VMLAUNCH instruction */
static int handle_vmlaunch(struct kvm_vcpu *vcpu)
{
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration
2020-01-23 2:08 [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration linmiaohe
@ 2020-01-23 8:18 ` Vitaly Kuznetsov
2020-01-23 22:21 ` Krish Sadhukhan
1 sibling, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2020-01-23 8:18 UTC (permalink / raw)
To: linmiaohe
Cc: kvm, linux-kernel, x86, pbonzini, rkrcmar, sean.j.christopherson,
wanpengli, jmattson, joro, tglx, mingo, bp, hpa
linmiaohe <linmiaohe@huawei.com> writes:
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> The function nested_vmx_run() declaration is below its implementation. So
> this is meaningless and should be removed.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> arch/x86/kvm/vmx/nested.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 95b3f4306ac2..7608924ee8c1 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -4723,8 +4723,6 @@ static int handle_vmclear(struct kvm_vcpu *vcpu)
> return nested_vmx_succeed(vcpu);
> }
>
> -static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch);
> -
> /* Emulate the VMLAUNCH instruction */
> static int handle_vmlaunch(struct kvm_vcpu *vcpu)
> {
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration
2020-01-23 2:08 [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration linmiaohe
2020-01-23 8:18 ` Vitaly Kuznetsov
@ 2020-01-23 22:21 ` Krish Sadhukhan
1 sibling, 0 replies; 3+ messages in thread
From: Krish Sadhukhan @ 2020-01-23 22:21 UTC (permalink / raw)
To: linmiaohe, pbonzini, rkrcmar, sean.j.christopherson, vkuznets,
wanpengli, jmattson, joro, tglx, mingo, bp, hpa
Cc: kvm, linux-kernel, x86
On 01/22/2020 06:08 PM, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> The function nested_vmx_run() declaration is below its implementation. So
> this is meaningless and should be removed.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> arch/x86/kvm/vmx/nested.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 95b3f4306ac2..7608924ee8c1 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -4723,8 +4723,6 @@ static int handle_vmclear(struct kvm_vcpu *vcpu)
> return nested_vmx_succeed(vcpu);
> }
>
> -static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch);
> -
> /* Emulate the VMLAUNCH instruction */
> static int handle_vmlaunch(struct kvm_vcpu *vcpu)
> {
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-23 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-23 2:08 [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration linmiaohe
2020-01-23 8:18 ` Vitaly Kuznetsov
2020-01-23 22:21 ` Krish Sadhukhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).