* [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull
@ 2019-03-04 21:48 Helen Koike
2019-03-04 22:10 ` Stefan Wahren
0 siblings, 1 reply; 3+ messages in thread
From: Helen Koike @ 2019-03-04 21:48 UTC (permalink / raw)
To: eric
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, stefan.wahren,
linus.walleij, lkundrak, bcm-kernel-feedback-list, devicetree,
kernel
Raspberry pi board model B revison 2 have the hot plug detector gpio
active high (and not low as it was in the dts).
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
---
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 5641d162dfdb..28e7513ce617 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -93,7 +93,7 @@
};
&hdmi {
- hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
+ hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
};
&pwm {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull
2019-03-04 21:48 [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull Helen Koike
@ 2019-03-04 22:10 ` Stefan Wahren
2019-03-04 23:26 ` Eric Anholt
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Wahren @ 2019-03-04 22:10 UTC (permalink / raw)
To: Helen Koike, eric
Cc: devicetree, linus.walleij, linux-kernel, lkundrak,
bcm-kernel-feedback-list, linux-rpi-kernel, kernel,
linux-arm-kernel
Hi,
since this patch change only one board, the subject could be more specific:
ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull
> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 22:48 geschrieben:
>
>
> Raspberry pi board model B revison 2 have the hot plug detector gpio
> active high (and not low as it was in the dts).
>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> Reviewed-by: Eric Anholt <eric@anholt.net>
I think we should add a Fixes tag here, so it could be backported.
@Eric: Feel free to take V2
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull
2019-03-04 22:10 ` Stefan Wahren
@ 2019-03-04 23:26 ` Eric Anholt
0 siblings, 0 replies; 3+ messages in thread
From: Eric Anholt @ 2019-03-04 23:26 UTC (permalink / raw)
To: Stefan Wahren, Helen Koike
Cc: devicetree, linus.walleij, linux-kernel, lkundrak,
bcm-kernel-feedback-list, linux-rpi-kernel, kernel,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Hi,
>
> since this patch change only one board, the subject could be more specific:
>
> ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull
>
>> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 22:48 geschrieben:
>>
>>
>> Raspberry pi board model B revison 2 have the hot plug detector gpio
>> active high (and not low as it was in the dts).
>>
>> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> I think we should add a Fixes tag here, so it could be backported.
>
> @Eric: Feel free to take V2
Added a fixes tag, and I'll submit PRs for this and the PM fixes now.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-04 23:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 21:48 [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull Helen Koike
2019-03-04 22:10 ` Stefan Wahren
2019-03-04 23:26 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).