* [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init()
@ 2016-08-25 16:07 SF Markus Elfring
2016-08-29 19:59 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2016-08-25 16:07 UTC (permalink / raw)
To: linux-arm-kernel, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
Russell King
Cc: LKML, kernel-janitors, Julia Lawall, Paolo Bonzini
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 25 Aug 2016 18:01:37 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/arm/mach-pxa/pm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-pxa/pm.c b/arch/arm/mach-pxa/pm.c
index 388463b..e7450fb 100644
--- a/arch/arm/mach-pxa/pm.c
+++ b/arch/arm/mach-pxa/pm.c
@@ -104,8 +104,9 @@ static int __init pxa_pm_init(void)
return -EINVAL;
}
- sleep_save = kmalloc(pxa_cpu_pm_fns->save_count * sizeof(unsigned long),
- GFP_KERNEL);
+ sleep_save = kmalloc_array(pxa_cpu_pm_fns->save_count,
+ sizeof(*sleep_save),
+ GFP_KERNEL);
if (!sleep_save) {
printk(KERN_ERR "failed to alloc memory for pm save\n");
return -ENOMEM;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init()
2016-08-25 16:07 [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init() SF Markus Elfring
@ 2016-08-29 19:59 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2016-08-29 19:59 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-arm-kernel, Daniel Mack, Haojian Zhuang, Russell King,
LKML, kernel-janitors, Julia Lawall, Paolo Bonzini
SF Markus Elfring <elfring@users.sourceforge.net> writes:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 25 Aug 2016 18:01:37 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> * Replace the specification of a data type by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Queued to pxa/for-next, thanks.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-29 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25 16:07 [PATCH] ARM: pxa: Use kmalloc_array() in pxa_pm_init() SF Markus Elfring
2016-08-29 19:59 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).