* [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL
@ 2016-08-22 3:19 Kuninori Morimoto
2016-08-22 7:52 ` Zhang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2016-08-22 3:19 UTC (permalink / raw)
To: Zhang Rui, edubezval; +Cc: linux-kernel, linux-renesas-soc, linux-pm, PhucBui
From: Bui Duc Phuc <bd-phuc@jinso.co.jp>
devm_thermal_zone_of_sensor_register() case doesn't need to call
thermal_zone_device_unregister().
Otherwise, rcar-thermal can't register thermal zone again after rebind.
This patch fixes it.
Signed-off-by: Bui Duc Phuc <bd-phuc@jinso.co.jp>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/thermal/rcar_thermal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 4d07644..b5c6442 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -419,9 +419,10 @@ static int rcar_thermal_remove(struct platform_device *pdev)
rcar_thermal_for_each_priv(priv, common) {
rcar_thermal_irq_disable(priv);
- thermal_zone_device_unregister(priv->zone);
if (rcar_use_of_thermal(dev))
thermal_remove_hwmon_sysfs(priv->zone);
+ else
+ thermal_zone_device_unregister(priv->zone);
}
pm_runtime_put(dev);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL
2016-08-22 3:19 [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL Kuninori Morimoto
@ 2016-08-22 7:52 ` Zhang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Zhang Rui @ 2016-08-22 7:52 UTC (permalink / raw)
To: Kuninori Morimoto, edubezval
Cc: linux-kernel, linux-renesas-soc, linux-pm, PhucBui
On 一, 2016-08-22 at 03:19 +0000, Kuninori Morimoto wrote:
> From: Bui Duc Phuc <bd-phuc@jinso.co.jp>
>
> devm_thermal_zone_of_sensor_register() case doesn't need to call
> thermal_zone_device_unregister().
> Otherwise, rcar-thermal can't register thermal zone again after
> rebind.
> This patch fixes it.
>
> Signed-off-by: Bui Duc Phuc <bd-phuc@jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Patch applied.
thanks,
rui
> ---
> drivers/thermal/rcar_thermal.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c
> index 4d07644..b5c6442 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -419,9 +419,10 @@ static int rcar_thermal_remove(struct
> platform_device *pdev)
>
> rcar_thermal_for_each_priv(priv, common) {
> rcar_thermal_irq_disable(priv);
> - thermal_zone_device_unregister(priv->zone);
> if (rcar_use_of_thermal(dev))
> thermal_remove_hwmon_sysfs(priv->zone);
> + else
> + thermal_zone_device_unregister(priv->zone);
> }
>
> pm_runtime_put(dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-22 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22 3:19 [PATCH] thermal: rcar_thermal: don't call thermal_zone_device_unregister when USE_OF_THERMAL Kuninori Morimoto
2016-08-22 7:52 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).