From: Kalle Valo <kvalo@codeaurora.org>
To: "Pan\, Miaoqing" <miaoqing@qti.qualcomm.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>,
"linux-next\@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"ath9k-devel\@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
Miaoqing Pan <miaoqing@codeaurora.org>
Subject: Re: ath9k gpio request
Date: Fri, 03 Jun 2016 08:33:11 +0300 [thread overview]
Message-ID: <8760tqn8fc.fsf@purkki.adurom.net> (raw)
In-Reply-To: <57501AE4.7080104@gmail.com> (Sudip Mukherjee's message of "Thu, 02 Jun 2016 17:09:16 +0530")
Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:
> On Thursday 02 June 2016 01:32 PM, Pan, Miaoqing wrote:
>> Seems there are something wrong in the datasheet, try
>>
>> --- a/drivers/net/wireless/ath/ath9k/reg.h
>> +++ b/drivers/net/wireless/ath/ath9k/reg.h
>> @@ -1122,8 +1122,8 @@ enum {
>> #define AR9300_NUM_GPIO 16
>> #define AR9330_NUM_GPIO 16
>> #define AR9340_NUM_GPIO 23
>> -#define AR9462_NUM_GPIO 10
>> -#define AR9485_NUM_GPIO 12
>> +#define AR9462_NUM_GPIO 14
>> +#define AR9485_NUM_GPIO 11
>> #define AR9531_NUM_GPIO 18
>> #define AR9550_NUM_GPIO 24
>> #define AR9561_NUM_GPIO 23
>> @@ -1139,8 +1139,8 @@ enum {
>> #define AR9300_GPIO_MASK 0x0000F4FF
>> #define AR9330_GPIO_MASK 0x0000F4FF
>> #define AR9340_GPIO_MASK 0x0000000F
>> -#define AR9462_GPIO_MASK 0x000003FF
>> -#define AR9485_GPIO_MASK 0x00000FFF
>> +#define AR9462_GPIO_MASK 0x00003FFF
>> +#define AR9485_GPIO_MASK 0x000007FF
>> #define AR9531_GPIO_MASK 0x0000000F
>> #define AR9550_GPIO_MASK 0x0000000F
>> #define AR9561_GPIO_MASK 0x0000000F
>
> solves the problem.
>
> Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Great, thanks for testing everyone. Miaoqing, please send a proper patch
ASAP and I'll push it to 4.7.
--
Kalle Valo
next prev parent reply other threads:[~2016-06-03 5:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 3:22 linux-next: Tree for May 30 Stephen Rothwell
2016-05-30 14:04 ` Sudip Mukherjee
2016-05-31 7:31 ` ath9k gpio request Kalle Valo
2016-05-31 7:35 ` Sudip Mukherjee
2016-06-01 6:54 ` Pan, Miaoqing
2016-06-01 11:12 ` Sudip Mukherjee
2016-06-01 12:18 ` Sudip Mukherjee
2016-06-02 8:02 ` Pan, Miaoqing
2016-06-02 9:01 ` Janusz Dziedzic
2016-06-02 11:39 ` Sudip Mukherjee
2016-06-03 5:33 ` Kalle Valo [this message]
2016-06-03 5:49 ` Pan, Miaoqing
2016-06-04 14:37 ` Kalle Valo
2016-06-05 17:40 ` Sudip Mukherjee
2016-06-07 11:43 ` Kalle Valo
2016-06-06 1:51 ` Pan, Miaoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760tqn8fc.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
--cc=miaoqing@qti.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).