Re: [PATCH 6/6] intel_sgx: TODO file for the staging area

From: Andi Kleen <andi@firstfloor.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: gregkh@linuxfoundation.org,
	"open list\:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] intel_sgx: TODO file for the staging area
Date: Mon, 25 Apr 2016 13:01:24 -0700	[thread overview]
Message-ID: <8760v55ugb.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <1461605698-12385-7-git-send-email-jarkko.sakkinen@linux.intel.com> (Jarkko Sakkinen's message of "Mon, 25 Apr 2016 20:34:13 +0300")

Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> writes:

> diff --git a/drivers/staging/intel_sgx/TODO b/drivers/staging/intel_sgx/TODO
> new file mode 100644
> index 0000000..05f68c2
> --- /dev/null
> +++ b/drivers/staging/intel_sgx/TODO
> @@ -0,0 +1,25 @@
> +Documentation
> +=============
> +
> +* Improve Documents/x86/intel-sgx.txt based on the feedback and
> +  questions that pop up.
> +
> +Internals
> +=========
> +
> +* Move structures needed by the allocator to arch/x86/include/asm/sgx.h
> +* Move EPC page allocation and eviction code to arch/x86/mm as they
> +  will shared with virtualization code.
> +* Move enclave management functions to arch/x86/mm as they will be
> +  shared with virtualization code.
> +* Use reserve_memtype() in order to add EPC to the PAT memtype list
> +  with WB caching.
> +* Implement proper recovery code for the pager for cases when
> +  ETRACK/EBLOCK/EWB fails instead of BUG_ON(). Probably the sanest
> +  way to recover is to clear TCS PTEs, kick threads out of enclave
> +  and remove EPC pages.
> +* Implement ACPI hot-lug for SGX.

- Write proper patch descriptions.

Especially how the "new VM" in 3/6 works needs a lot more explanation ...

- Add some test code

-Andi